Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2826513002: color: Use named gamuts in ToSkColorSpace (Closed)

Created:
3 years, 8 months ago by ccameron
Modified:
3 years, 8 months ago
Reviewers:
zakerinasab, msarett1
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

color: Use named gamuts in ToSkColorSpace BUG=712266 Review-Url: https://codereview.chromium.org/2826513002 Cr-Commit-Position: refs/heads/master@{#465071} Committed: https://chromium.googlesource.com/chromium/src/+/9962fbabc5fadbcb8e5aaead8681474f0fe761e0

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add named gamut parametric trfn #

Patch Set 3 : Add named gamut parametric trfn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -11 lines) Patch
M ui/gfx/color_space.cc View 1 1 chunk +43 lines, -11 lines 0 comments Download
M ui/gfx/color_space_unittest.cc View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
ccameron
ptal -- should fix the immediate issues that you're seeing (as is cleaner to read ...
3 years, 8 months ago (2017-04-17 19:47:08 UTC) #2
zakerinasab
On 2017/04/17 19:47:08, ccameron wrote: > ptal -- should fix the immediate issues that you're ...
3 years, 8 months ago (2017-04-17 20:15:50 UTC) #3
ccameron
np!
3 years, 8 months ago (2017-04-17 20:17:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826513002/1
3 years, 8 months ago (2017-04-17 20:18:10 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-17 20:18:11 UTC) #8
ccameron
Adding msarett for committer LG
3 years, 8 months ago (2017-04-17 21:26:42 UTC) #10
msarett1
lgtm https://codereview.chromium.org/2826513002/diff/1/ui/gfx/color_space.cc File ui/gfx/color_space.cc (right): https://codereview.chromium.org/2826513002/diff/1/ui/gfx/color_space.cc#newcode470 ui/gfx/color_space.cc:470: return SkColorSpace::MakeRGB(named_gamma, to_xyz_d50); Is there ever a case ...
3 years, 8 months ago (2017-04-17 21:30:43 UTC) #11
ccameron
https://codereview.chromium.org/2826513002/diff/1/ui/gfx/color_space.cc File ui/gfx/color_space.cc (right): https://codereview.chromium.org/2826513002/diff/1/ui/gfx/color_space.cc#newcode470 ui/gfx/color_space.cc:470: return SkColorSpace::MakeRGB(named_gamma, to_xyz_d50); On 2017/04/17 21:30:43, msarett1 wrote: > ...
3 years, 8 months ago (2017-04-17 23:08:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826513002/40001
3 years, 8 months ago (2017-04-17 23:08:43 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 00:10:22 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9962fbabc5fadbcb8e5aaead8681...

Powered by Google App Engine
This is Rietveld 408576698