color: Use named gamuts in ToSkColorSpace

color: Use named gamuts in ToSkColorSpace

BUG=712266
Review-Url: https://codereview.chromium.org/2826513002
Cr-Commit-Position: refs/heads/master@{#465071}
Committed: https://chromium.googlesource.com/chromium/src/+/9962fbabc5fadbcb8e5aaead8681474f0fe761e0

[ccameron, 2017-04-17 19:47:08]

ccameron@chromium.org changed reviewers:
+ zakerinasab@chromium.org

[ccameron, 2017-04-17 19:47:08]

ptal -- should fix the immediate issues that you're seeing (as is cleaner to
read this way IMO).

[zakerinasab, 2017-04-17 20:15:50]

On 2017/04/17 19:47:08, ccameron wrote:
> ptal -- should fix the immediate issues that you're seeing (as is cleaner to
> read this way IMO).

lgtm. Thanks for putting this up fast.

[ccameron, 2017-04-17 20:17:34]

np!

[ccameron, 2017-04-17 20:17:40]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-04-17 20:18:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 20:18:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 20:18:11]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[ccameron, 2017-04-17 21:26:42]

ccameron@chromium.org changed reviewers:
+ msarett@chromium.org

[ccameron, 2017-04-17 21:26:42]

Adding msarett for committer LG

[msarett1, 2017-04-17 21:30:43]

lgtm

https://codereview.chromium.org/2826513002/diff/1/ui/gfx/color_space.cc
File ui/gfx/color_space.cc (right):

https://codereview.chromium.org/2826513002/diff/1/ui/gfx/color_space.cc#newco...
ui/gfx/color_space.cc:470: return SkColorSpace::MakeRGB(named_gamma,
to_xyz_d50);
Is there ever a case where has_named_gamut is true, but has_named_gamma is not?

[ccameron, 2017-04-17 23:08:05]

https://codereview.chromium.org/2826513002/diff/1/ui/gfx/color_space.cc
File ui/gfx/color_space.cc (right):

https://codereview.chromium.org/2826513002/diff/1/ui/gfx/color_space.cc#newco...
ui/gfx/color_space.cc:470: return SkColorSpace::MakeRGB(named_gamma,
to_xyz_d50);
On 2017/04/17 21:30:43, msarett1 wrote:
> Is there ever a case where has_named_gamut is true, but has_named_gamma is
not?

Good point -- added that case.

[ccameron, 2017-04-17 23:08:15]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-04-17 23:08:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
zakerinasab@chromium.org, msarett@chromium.org
Link to the patchset: https://codereview.chromium.org/2826513002/#ps40001
(title: "Add named gamut parametric trfn")

[commit-bot: I haz the power, 2017-04-17 23:08:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 00:10:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492470495975260,
"parent_rev": "63b2fd059db083da191d2dd9c53eb680baf2e010", "commit_rev":
"9962fbabc5fadbcb8e5aaead8681474f0fe761e0"}

[commit-bot: I haz the power, 2017-04-18 00:10:22]

Description was changed from

==========
color: Use named gamuts in ToSkColorSpace

BUG=712266
==========

to

==========
color: Use named gamuts in ToSkColorSpace

BUG=712266

Review-Url: https://codereview.chromium.org/2826513002
Cr-Commit-Position: refs/heads/master@{#465071}
Committed:
https://chromium.googlesource.com/chromium/src/+/9962fbabc5fadbcb8e5aaead8681...
==========

[commit-bot: I haz the power, 2017-04-18 00:10:22]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9962fbabc5fadbcb8e5aaead8681...