Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2826493003:
[DMC #3] Prepare DocumentMarkerController for using different DocumentMarkerList impls (Closed)
DescriptionPrepare DocumentMarkerController for using different DocumentMarkerList impls
I'm going to start writing different implementations of DocumentMarkerList for
the different MarkerTypes. This CL prepares us to be able to easily specify the
marker list class we want to use for each MarkerType.
BUG=707867
Review-Url: https://codereview.chromium.org/2826493003
Cr-Commit-Position: refs/heads/master@{#467609}
Committed: https://chromium.googlesource.com/chromium/src/+/4dbe8b7c5c9762619c4baf47e4650a9d8139d48f
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #Patch Set 4 : Rebase #Patch Set 5 : Rebase #Patch Set 6 : Rebase #Messages
Total messages: 29 (24 generated)
Description was changed from ========== Prepare DocumentMarkerController for using different DocumentMarkerList impls BUG=707867 ========== to ========== Prepare DocumentMarkerController for using different DocumentMarkerList impls I'm going to start writing different implementations of DocumentMarkerList for the different MarkerTypes. This CL prepares us to be able to easily specify the marker list class we want to use for each MarkerType. BUG=707867 ==========
rlanday@chromium.org changed reviewers: + xiaochengh@chromium.org, yoichio@chromium.org, yosin@chromium.org
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Seems pretty straightforward, so lgtm assuming there's no major change in DMC#2.
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by rlanday@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xiaochengh@chromium.org Link to the patchset: https://codereview.chromium.org/2826493003/#ps100001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493258544549280,
"parent_rev": "1339ec6addf0faa53da2c7418a0de5b6803d89cf", "commit_rev":
"4dbe8b7c5c9762619c4baf47e4650a9d8139d48f"}
Message was sent while issue was closed.
Description was changed from ========== Prepare DocumentMarkerController for using different DocumentMarkerList impls I'm going to start writing different implementations of DocumentMarkerList for the different MarkerTypes. This CL prepares us to be able to easily specify the marker list class we want to use for each MarkerType. BUG=707867 ========== to ========== Prepare DocumentMarkerController for using different DocumentMarkerList impls I'm going to start writing different implementations of DocumentMarkerList for the different MarkerTypes. This CL prepares us to be able to easily specify the marker list class we want to use for each MarkerType. BUG=707867 Review-Url: https://codereview.chromium.org/2826493003 Cr-Commit-Position: refs/heads/master@{#467609} Committed: https://chromium.googlesource.com/chromium/src/+/4dbe8b7c5c9762619c4baf47e465... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/4dbe8b7c5c9762619c4baf47e465... |
