[Sync] Refactor get_commit_ids.cc without any functional changes.

[Sync] Refactor get_commit_ids.cc without any functional changes.

BUG=711381
Review-Url: https://codereview.chromium.org/2826473002
Cr-Commit-Position: refs/heads/master@{#465017}
Committed: https://chromium.googlesource.com/chromium/src/+/4f41087cb29ed77a0840c22cee5b5c30011b8112

[skym, 2017-04-17 16:59:18]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 16:59:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2017-04-17 17:15:41]

Description was changed from

==========
Refactor get_commit_ids.cc without any functional changes.

BUG=711381
==========

to

==========
[Sync] Refactor get_commit_ids.cc without any functional changes.

BUG=711381
==========

[skym, 2017-04-17 18:15:29]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[skym, 2017-04-17 18:15:37]

skym@chromium.org changed reviewers:
+ pavely@chromium.org

[skym, 2017-04-17 18:15:38]

PTAL

[commit-bot: I haz the power, 2017-04-17 18:15:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 19:06:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 19:06:22]

Dry run: This issue passed the CQ dry run.

[pavely, 2017-04-17 19:22:20]

lgtm

https://codereview.chromium.org/2826473002/diff/40001/components/sync/engine_...
File components/sync/engine_impl/get_commit_ids.cc (left):

https://codereview.chromium.org/2826473002/diff/40001/components/sync/engine_...
components/sync/engine_impl/get_commit_ids.cc:129:
syncable::EntryNeedsEncryption(encrypted_types, entry))) {
This change works because of ADL. It expands set of namespaces to search for
EntryNeedsEncryption while making it slightly harder for reader to find its
definition. What do you think about keeping namespace?

[skym, 2017-04-17 20:22:43]

https://codereview.chromium.org/2826473002/diff/40001/components/sync/engine_...
File components/sync/engine_impl/get_commit_ids.cc (left):

https://codereview.chromium.org/2826473002/diff/40001/components/sync/engine_...
components/sync/engine_impl/get_commit_ids.cc:129:
syncable::EntryNeedsEncryption(encrypted_types, entry))) {
On 2017/04/17 19:22:20, pavely wrote:
> This change works because of ADL. It expands set of namespaces to search for
> EntryNeedsEncryption while making it slightly harder for reader to find its
> definition. What do you think about keeping namespace?

Whoops, a casualty of search and replace. Added it back.

[skym, 2017-04-17 20:23:03]

The CQ bit was checked by skym@chromium.org

[skym, 2017-04-17 20:23:03]

The patchset sent to the CQ was uploaded after l-g-t-m from pavely@chromium.org
Link to the patchset: https://codereview.chromium.org/2826473002/#ps60001
(title: "Adding back namespace to static function.")

[commit-bot: I haz the power, 2017-04-17 20:23:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 21:13:34]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492460583540390,
"parent_rev": "09cd8622560496d63dd16d0b10a7c515dbc5c3ff", "commit_rev":
"4f41087cb29ed77a0840c22cee5b5c30011b8112"}

[commit-bot: I haz the power, 2017-04-17 21:13:44]

Description was changed from

==========
[Sync] Refactor get_commit_ids.cc without any functional changes.

BUG=711381
==========

to

==========
[Sync] Refactor get_commit_ids.cc without any functional changes.

BUG=711381

Review-Url: https://codereview.chromium.org/2826473002
Cr-Commit-Position: refs/heads/master@{#465017}
Committed:
https://chromium.googlesource.com/chromium/src/+/4f41087cb29ed77a0840c22cee5b...
==========

[commit-bot: I haz the power, 2017-04-17 21:13:45]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4f41087cb29ed77a0840c22cee5b...