Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2826453003: Makes functions in container_finder take aura::Window (Closed)

Created:
3 years, 8 months ago by sky
Modified:
3 years, 8 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes functions in container_finder take aura::Window BUG=687656 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2826453003 Cr-Commit-Position: refs/heads/master@{#465049} Committed: https://chromium.googlesource.com/chromium/src/+/fa0a83ccea48b98b3c8a7facd068a41bc92f21f1

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -69 lines) Patch
M ash/mus/top_level_window_factory.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ash/mus/window_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/root_window_controller.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M ash/system/tray/system_tray.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ash/system/tray/tray_event_filter.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M ash/wm/container_finder.h View 1 chunk +3 lines, -6 lines 0 comments Download
M ash/wm/container_finder.cc View 2 chunks +43 lines, -37 lines 0 comments Download
M ash/wm/container_finder_unittest.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M ash/wm/stacking_controller.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
sky
3 years, 8 months ago (2017-04-17 21:55:59 UTC) #1
msw
lgtm
3 years, 8 months ago (2017-04-17 22:13:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826453003/20001
3 years, 8 months ago (2017-04-17 22:43:11 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 22:49:09 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fa0a83ccea48b98b3c8a7facd068...

Powered by Google App Engine
This is Rietveld 408576698