[ES6 modules] Cosmetic changes to ModuleTreeLinker

[ES6 modules] Cosmetic changes to ModuleTreeLinker

- Minor comment fixes to ModuleTreeLinker.
- Use Vector instead of HashSet for "#fetch-the-descendants-of-a-module-script"

This CL addresses review comments in
https://codereview.chromium.org/2823803003/

BUG=594639
Review-Url: https://codereview.chromium.org/2826423002
Cr-Commit-Position: refs/heads/master@{#466581}
Committed: https://chromium.googlesource.com/chromium/src/+/3df03ef75837bd7664e17fa0daab5ea2f0bef0da

[kouhei (in TOK), 2017-04-20 08:58:48]

kouhei@chromium.org changed reviewers:
+ hiroshige@chromium.org, kinuko@chromium.org

[kouhei (in TOK), 2017-04-20 08:59:08]

kouhei@chromium.org changed reviewers:
+ japhet@chromium.org, nhiroki@chromium.org

[nhiroki, 2017-04-20 09:06:25]

lgtm with nits

https://codereview.chromium.org/2826423002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp
(right):

https://codereview.chromium.org/2826423002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp:13:
#include "platform/wtf/HashSet.h"
"HashSet.h" may be unused (HeapHashSet is defined in HeapAllocator.h)

Can you add Vector.h?

[kinuko, 2017-04-20 09:13:49]

lgtm

[hiroshige, 2017-04-20 09:38:47]

lgtm

https://codereview.chromium.org/2826423002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp
(right):

https://codereview.chromium.org/2826423002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp:146: //
case |descendants_module_script_| is always null)
small nit: extra ')' at the end of the line.

[kouhei (in TOK), 2017-04-24 01:07:11]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2017-04-24 01:07:12]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
hiroshige@chromium.org, nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2826423002/#ps40001
(title: "nhiroki/hiroshige")

[commit-bot: I haz the power, 2017-04-24 01:07:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 02:50:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492996031973520,
"parent_rev": "00e4fb83516d445e8952416ed29a481b399a0a24", "commit_rev":
"3df03ef75837bd7664e17fa0daab5ea2f0bef0da"}

[commit-bot: I haz the power, 2017-04-24 02:50:40]

Description was changed from

==========
[ES6 modules] Cosmetic changes to ModuleTreeLinker

- Minor comment fixes to ModuleTreeLinker.
- Use Vector instead of HashSet for "#fetch-the-descendants-of-a-module-script"

This CL addresses review comments in
https://codereview.chromium.org/2823803003/

BUG=594639
==========

to

==========
[ES6 modules] Cosmetic changes to ModuleTreeLinker

- Minor comment fixes to ModuleTreeLinker.
- Use Vector instead of HashSet for "#fetch-the-descendants-of-a-module-script"

This CL addresses review comments in
https://codereview.chromium.org/2823803003/

BUG=594639

Review-Url: https://codereview.chromium.org/2826423002
Cr-Commit-Position: refs/heads/master@{#466581}
Committed:
https://chromium.googlesource.com/chromium/src/+/3df03ef75837bd7664e17fa0daab...
==========

[commit-bot: I haz the power, 2017-04-24 02:50:41]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3df03ef75837bd7664e17fa0daab...