use devtools command to do window management

use devtools command to do window management

BUG=604324
Review-Url: https://codereview.chromium.org/2826393002
Cr-Commit-Position: refs/heads/master@{#466284}
Committed: https://chromium.googlesource.com/chromium/src/+/74934b2b5f8665e2d2f5eb77b5494ff06d9df114

[jzfeng, 2017-04-20 08:04:48]

The CQ bit was checked by jzfeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 08:05:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jzfeng, 2017-04-20 08:19:57]

jzfeng@chromium.org changed reviewers:
+ johnchen@chromium.org

[jzfeng, 2017-04-20 08:19:57]

This patch let chromedriver to manage window via devtools commands, when the
chrome build no is after the commands were added.

PTAL.

[commit-bot: I haz the power, 2017-04-20 08:42:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 08:42:31]

Dry run: This issue passed the CQ dry run.

[johnchen, 2017-04-20 18:48:21]

lgtm

[jzfeng, 2017-04-21 01:41:44]

The CQ bit was checked by jzfeng@chromium.org

[jzfeng, 2017-04-21 01:41:44]

Thanks for the review!

[commit-bot: I haz the power, 2017-04-21 01:42:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 01:42:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 01:42:16]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[jzfeng, 2017-04-21 01:48:24]

jzfeng@chromium.org changed reviewers:
+ stgao@chromium.org

[jzfeng, 2017-04-21 01:50:36]

Hi Shuotao,

Would you mind taking a look at the patch? I checked that you are the reviewer
of the previous chromedriver CLs.

Thanks!

[stgao, 2017-04-21 05:06:31]

lgtm % comments.

https://codereview.chromium.org/2826393002/diff/1/chrome/test/chromedriver/ch...
File chrome/test/chromedriver/chrome/chrome_desktop_impl.cc (right):

https://codereview.chromium.org/2826393002/diff/1/chrome/test/chromedriver/ch...
chrome/test/chromedriver/chrome/chrome_desktop_impl.cc:290: // always restore
window to normal first.
Maybe some more detail on why.

https://codereview.chromium.org/2826393002/diff/1/chrome/test/chromedriver/ch...
File chrome/test/chromedriver/chrome/chrome_desktop_impl.h (right):

https://codereview.chromium.org/2826393002/diff/1/chrome/test/chromedriver/ch...
chrome/test/chromedriver/chrome/chrome_desktop_impl.h:70: Status
GetWindowPosition(std::string target_id, int* x, int* y);
const std::string & target_id ?

same for below.

[jzfeng, 2017-04-21 07:25:53]

The CQ bit was checked by jzfeng@chromium.org

[jzfeng, 2017-04-21 07:25:54]

Thanks for the review!

https://codereview.chromium.org/2826393002/diff/1/chrome/test/chromedriver/ch...
File chrome/test/chromedriver/chrome/chrome_desktop_impl.cc (right):

https://codereview.chromium.org/2826393002/diff/1/chrome/test/chromedriver/ch...
chrome/test/chromedriver/chrome/chrome_desktop_impl.cc:290: // always restore
window to normal first.
On 2017/04/21 at 05:06:31, stgao(ping after 24h) wrote:
> Maybe some more detail on why.

Done.

https://codereview.chromium.org/2826393002/diff/1/chrome/test/chromedriver/ch...
File chrome/test/chromedriver/chrome/chrome_desktop_impl.h (right):

https://codereview.chromium.org/2826393002/diff/1/chrome/test/chromedriver/ch...
chrome/test/chromedriver/chrome/chrome_desktop_impl.h:70: Status
GetWindowPosition(std::string target_id, int* x, int* y);
On 2017/04/21 at 05:06:31, stgao(ping after 24h) wrote:
> const std::string & target_id ?
> 
> same for below.

Done.

[jzfeng, 2017-04-21 07:25:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
johnchen@chromium.org, stgao@chromium.org
Link to the patchset: https://codereview.chromium.org/2826393002/#ps20001
(title: "nit change")

[commit-bot: I haz the power, 2017-04-21 07:26:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 07:36:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492759553834110,
"parent_rev": "3a05731eee64a75591868d5dfb4baf4bf42bd3a1", "commit_rev":
"74934b2b5f8665e2d2f5eb77b5494ff06d9df114"}

[commit-bot: I haz the power, 2017-04-21 07:36:46]

Description was changed from

==========
use devtools command to do window management

BUG=604324
==========

to

==========
use devtools command to do window management

BUG=604324

Review-Url: https://codereview.chromium.org/2826393002
Cr-Commit-Position: refs/heads/master@{#466284}
Committed:
https://chromium.googlesource.com/chromium/src/+/74934b2b5f8665e2d2f5eb77b549...
==========

[commit-bot: I haz the power, 2017-04-21 07:36:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/74934b2b5f8665e2d2f5eb77b549...