Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2826373002: Move CompositionUnderlineVectorBuilder.* from web/ -> core/editing/. (Closed)
Patch Set: Change CompositionUnderlineVectorBuilder to have an explicit method to build a Vector, rather than … Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.cpp ('K') | « third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index ff37425527755ddafdea159cfee9727e97708d26..4e5eb5b7ddd4c2f638e1309535b40280c5026be9 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -109,6 +109,7 @@
#include "core/dom/Node.h"
#include "core/dom/NodeTraversal.h"
#include "core/dom/shadow/ShadowRoot.h"
+#include "core/editing/CompositionUnderlineVectorBuilder.h"
#include "core/editing/EditingUtilities.h"
#include "core/editing/Editor.h"
#include "core/editing/FindInPageCoordinates.h"
@@ -222,7 +223,6 @@
#include "public/web/WebSerializedScriptValue.h"
#include "public/web/WebTreeScopeType.h"
#include "skia/ext/platform_canvas.h"
-#include "web/CompositionUnderlineVectorBuilder.h"
#include "web/RemoteFrameOwner.h"
#include "web/SharedWorkerRepositoryClientImpl.h"
#include "web/TextCheckerClientImpl.h"
@@ -1309,7 +1309,7 @@ bool WebLocalFrameImpl::SetCompositionFromExistingText(
GetFrame()->GetDocument()->UpdateStyleAndLayoutIgnorePendingStylesheets();
input_method_controller.SetCompositionFromExistingText(
- CompositionUnderlineVectorBuilder(underlines), composition_start,
+ CompositionUnderlineVectorBuilder::Build(underlines), composition_start,
composition_end);
return true;
« third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.cpp ('K') | « third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698