Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.cpp

Issue 2826373002: Move CompositionUnderlineVectorBuilder.* from web/ -> core/editing/. (Closed)
Patch Set: Change CompositionUnderlineVectorBuilder to have an explicit method to build a Vector, rather than … Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.cpp
diff --git a/third_party/WebKit/Source/web/CompositionUnderlineVectorBuilder.cpp b/third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.cpp
similarity index 87%
rename from third_party/WebKit/Source/web/CompositionUnderlineVectorBuilder.cpp
rename to third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.cpp
index 7c5979cffcf1a21a418bb4f27cd21a72c934dd35..cccfebbb9e891c0c59f68bd4b7b0732abfe02431 100644
--- a/third_party/WebKit/Source/web/CompositionUnderlineVectorBuilder.cpp
+++ b/third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.cpp
@@ -28,18 +28,18 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#include "web/CompositionUnderlineVectorBuilder.h"
-
-#include "web/CompositionUnderlineBuilder.h"
+#include "core/editing/CompositionUnderlineVectorBuilder.h"
namespace blink {
-CompositionUnderlineVectorBuilder::CompositionUnderlineVectorBuilder(
+Vector<CompositionUnderline> CompositionUnderlineVectorBuilder::Build(
const WebVector<WebCompositionUnderline>& underlines) {
+ Vector<CompositionUnderline> result;
slangley 2017/04/27 00:48:00 Note: Can't call ctor(size) here as no default cto
size_t size = underlines.size();
- ReserveCapacity(size);
+ result.ReserveCapacity(size);
for (size_t i = 0; i < size; ++i)
- push_back(CompositionUnderlineBuilder(underlines[i]));
+ result.push_back(underlines[i]);
+ return result;
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.h ('k') | third_party/WebKit/Source/web/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698