third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.h - Issue 2826373002: Move CompositionUnderlineVectorBuilder.* from web/ -> core/editing/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.h

Issue 2826373002: Move CompositionUnderlineVectorBuilder.* from web/ -> core/editing/. (Closed)

Patch Set: Change CompositionUnderlineVectorBuilder to have an explicit method to build a Vector, rather than … Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/CompositionUnderline.cpp ('k') | third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.cpp » ('j') | third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.h

diff --git a/third_party/WebKit/Source/web/CompositionUnderlineVectorBuilder.h b/third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.h

similarity index 86%

rename from third_party/WebKit/Source/web/CompositionUnderlineVectorBuilder.h

rename to third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.h

index a73bf86f47056b0d1cdec37ab18c160cd5d3ae09..9b44790d8db06aa2eec9e90e089b9c0560ab955a 100644

--- a/third_party/WebKit/Source/web/CompositionUnderlineVectorBuilder.h

+++ b/third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.h

@@ -31,6 +31,7 @@

#ifndef CompositionUnderlineVectorBuilder_h

#define CompositionUnderlineVectorBuilder_h

+#include "core/CoreExport.h"

#include "core/editing/CompositionUnderline.h"

#include "platform/wtf/Vector.h"

#include "public/platform/WebVector.h"

@@ -38,12 +39,15 @@

namespace blink {

-// This classes are used for converting from WebVector<WebCompositionUnderline>

+// This class is used for converting from WebVector<WebCompositionUnderline>

// to Vector<CompositionUnderline>.

-class CompositionUnderlineVectorBuilder : public Vector<CompositionUnderline> {

+class CompositionUnderlineVectorBuilder {

+ STATIC_ONLY(CompositionUnderlineVectorBuilder);

public:

- CompositionUnderlineVectorBuilder(const WebVector<WebCompositionUnderline>&);

+ CORE_EXPORT static Vector<CompositionUnderline> Build(

+ const WebVector<WebCompositionUnderline>&);

};

} // namespace blink