Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Issue 2826303002: MD Settings: Input method: fix icons (Closed)

Created:
3 years, 8 months ago by stevenjb
Modified:
3 years, 8 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Input method: fix icons BUG=710265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2826303002 Cr-Commit-Position: refs/heads/master@{#466829} Committed: https://chromium.googlesource.com/chromium/src/+/d68163e0c6061c0bd6ab8bade6d6fd9ea81a3c02

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/resources/settings/languages_page/languages_page.html View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
stevenjb
3 years, 8 months ago (2017-04-19 22:49:50 UTC) #3
michaelpg
lgtm % spelling corrections https://codereview.chromium.org/2826303002/diff/1/chrome/browser/resources/settings/languages_page/languages_page.html File chrome/browser/resources/settings/languages_page/languages_page.html (right): https://codereview.chromium.org/2826303002/diff/1/chrome/browser/resources/settings/languages_page/languages_page.html#newcode68 chrome/browser/resources/settings/languages_page/languages_page.html:68: indented list so this looks ...
3 years, 8 months ago (2017-04-21 02:23:57 UTC) #4
stevenjb
https://codereview.chromium.org/2826303002/diff/1/chrome/browser/resources/settings/languages_page/languages_page.html File chrome/browser/resources/settings/languages_page/languages_page.html (right): https://codereview.chromium.org/2826303002/diff/1/chrome/browser/resources/settings/languages_page/languages_page.html#newcode68 chrome/browser/resources/settings/languages_page/languages_page.html:68: indented list so this looks fine until mived: crbug.com/708286. ...
3 years, 8 months ago (2017-04-24 22:33:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826303002/20001
3 years, 8 months ago (2017-04-24 22:34:02 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 23:58:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d68163e0c6061c0bd6ab8bade6d6...

Powered by Google App Engine
This is Rietveld 408576698