Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2826293002: Enable wpt/css/css-flexbox-1 tests. (Closed)

Created:
3 years, 8 months ago by qyearsley
Modified:
3 years, 8 months ago
Reviewers:
cbiesinger
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable wpt/css/css-flexbox-1 tests. R=cbiesinger BUG=706118 Review-Url: https://codereview.chromium.org/2826293002 Cr-Commit-Position: refs/heads/master@{#466148} Committed: https://chromium.googlesource.com/chromium/src/+/f411f4206a67c0ba39493f379b5a9e939eb9d2ab

Patch Set 1 #

Patch Set 2 : Update NeverFixTests and Expectations #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -30 lines) Patch
M third_party/WebKit/LayoutTests/NeverFixTests View 1 1 chunk +22 lines, -0 lines 2 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 3 chunks +29 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
qyearsley
3 years, 8 months ago (2017-04-20 01:16:57 UTC) #1
cbiesinger
lgtm. I didn't realize we weren't running these for a couple weeks :( https://codereview.chromium.org/2826293002/diff/20001/third_party/WebKit/LayoutTests/NeverFixTests File ...
3 years, 8 months ago (2017-04-20 20:29:38 UTC) #2
qyearsley
> lgtm. I didn't realize we weren't running these for a couple weeks :( Sorry ...
3 years, 8 months ago (2017-04-20 20:31:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826293002/20001
3 years, 8 months ago (2017-04-20 20:32:49 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 21:43:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f411f4206a67c0ba39493f379b5a...

Powered by Google App Engine
This is Rietveld 408576698