Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2826283003: [wasm] Tests for Response instantiate APIs (Closed)

Created:
3 years, 8 months ago by Mircea Trofin
Modified:
3 years, 8 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[wasm] Tests for Response instantiate APIs BUG=chromium:697028 Review-Url: https://codereview.chromium.org/2826283003 Cr-Commit-Position: refs/heads/master@{#466174} Committed: https://chromium.googlesource.com/chromium/src/+/5e246838263416bcd05bf1b10c6c4d8582681a5a

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1063 lines, -6 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/wasm/resources/wasm-constants.js View 1 1 chunk +376 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/wasm/resources/wasm-module-builder.js View 1 1 chunk +581 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/wasm_streaming/wasm_response_apis.html View 1 1 chunk +11 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/wasm_streaming/wasm_response_apis.js View 3 chunks +95 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
Mircea Trofin
3 years, 8 months ago (2017-04-20 04:23:02 UTC) #3
jochen (gone - plz use gerrit)
I guess you mostly need my rubberstamp? lgtm once the tests actually pass :)
3 years, 8 months ago (2017-04-20 09:50:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826283003/20001
3 years, 8 months ago (2017-04-20 21:12:09 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 22:54:04 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5e246838263416bcd05bf1b10c6c...

Powered by Google App Engine
This is Rietveld 408576698