Enable loading gssapi library for Chromad.

Enable loading gssapi library for Chromad.

This enables building in Kerberos/gssapi support on Chrome OS
but only loads the library for Chromad enabled devices.

BUG=chromium:713709
R=asanka@chromium.org,rsleevi@chromium.org

Review-Url: https://codereview.chromium.org/2826273004
Cr-Commit-Position: refs/heads/master@{#470303}
Committed: https://chromium.googlesource.com/chromium/src/+/e03263581463ff17960eef46c3173bb28d9e3b8e

[zentaro, 2017-04-20 15:00:04]

The upload hooks tells me that the includes I added violated the deps.

Let me know if there is a better place I should do this check?

[asanka, 2017-04-20 18:00:52]

You'll need to plumb a preference down through HttpAuthPreferences which can be
found here:
https://cs.chromium.org/chromium/src/net/http/http_auth_preferences.h

Search for uses of HttpAuthPreferences and you'll see it being used in //chrome
to pass in auth preferences based on browser policies.

https://codereview.chromium.org/2826273004/diff/1/net/features.gni
File net/features.gni (right):

https://codereview.chromium.org/2826273004/diff/1/net/features.gni#newcode19
net/features.gni:19: # Enable Kerberos authentication. It is disabled by default
on ChromeOS, iOS,
Update comment.

https://codereview.chromium.org/2826273004/diff/1/net/http/http_auth_gssapi_p...
File net/http/http_auth_gssapi_posix.cc (right):

https://codereview.chromium.org/2826273004/diff/1/net/http/http_auth_gssapi_p...
net/http/http_auth_gssapi_posix.cc:22: #include
"chrome/browser/browser_process.h"
//net can't depend on //chrome. There are lots of components and embedders of
//net that don't include //chrome.

[zentaro, 2017-04-21 20:03:26]

The CQ bit was checked by zentaro@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 20:03:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 20:13:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 20:13:08]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[zentaro, 2017-04-24 17:12:02]

The CQ bit was checked by zentaro@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 17:12:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 17:41:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 17:41:46]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[zentaro, 2017-04-25 15:58:49]

The failed compilation is due to the fact that the kerberos library was not on
ARM devices. Since we haven't ported Samba to ARM yet we omitted the whole
dependency chain. However adding the dependency directly on kerberos seems
better than special casing ARM + CHROMEOS in chrome since eventually the rest of
the libraries will land on ARM anyway.

The other CL is https://chromium-review.googlesource.com/c/486250/ and will have
to land before this.

[zentaro, 2017-04-25 15:59:03]

PTAL

[asanka, 2017-04-26 20:42:25]

https://codereview.chromium.org/2826273004/diff/40001/net/http/http_auth_hand...
File net/http/http_auth_handler_factory.cc (right):

https://codereview.chromium.org/2826273004/diff/40001/net/http/http_auth_hand...
net/http/http_auth_handler_factory.cc:96: prefs.GssapiLibraryName(),
allow_gssapi_library_load));
Rather than this, let's make HttpAuthHandlerNegotiate::Factory fail if there's
no library. That way we can skip creating the library entirely on ChromeOS if
allow_gssapi_library_load is false.

It's seems unnecessary to construct a library that just returns
ERR_UNSUPPORTED_AUTH_SCHEME all the time.

[zentaro, 2017-04-27 18:52:08]

The CQ bit was checked by zentaro@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 18:52:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 19:34:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 19:34:40]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[zentaro, 2017-04-27 21:10:23]

The CQ bit was checked by zentaro@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:11:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 21:44:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 21:44:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[zentaro, 2017-04-28 13:09:00]

The CQ bit was checked by zentaro@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 13:09:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 13:38:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 13:38:37]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[zentaro, 2017-04-28 13:54:42]

PTAL

[asanka, 2017-04-28 14:13:03]

lgtm

[zentaro, 2017-05-08 14:06:45]

The CQ bit was checked by zentaro@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 14:06:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 15:23:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 15:23:12]

Dry run: This issue passed the CQ dry run.

[zentaro, 2017-05-08 15:25:37]

The CQ bit was checked by zentaro@chromium.org

[commit-bot: I haz the power, 2017-05-08 15:26:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 15:38:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 15:38:26]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[zentaro, 2017-05-08 19:07:06]

Description was changed from

==========
Enable loading gssapi library for Chromad.

This enables building in Kerberos/gssapi support on Chrome OS
but only loads the library for Chromad enabled devices.

BUG=chromium:713709
R=asanka@chromium.org
==========

to

==========
Enable loading gssapi library for Chromad.

This enables building in Kerberos/gssapi support on Chrome OS
but only loads the library for Chromad enabled devices.

BUG=chromium:713709
R=asanka@chromium.org
==========

[zentaro, 2017-05-08 19:07:06]

zentaro@chromium.org changed reviewers:
+ asanka (out until may 22);rsleevi@chromium.org
- asanka@chromium.org

[zentaro, 2017-05-08 19:07:45]

Description was changed from

==========
Enable loading gssapi library for Chromad.

This enables building in Kerberos/gssapi support on Chrome OS
but only loads the library for Chromad enabled devices.

BUG=chromium:713709
R=asanka@chromium.org
==========

to

==========
Enable loading gssapi library for Chromad.

This enables building in Kerberos/gssapi support on Chrome OS
but only loads the library for Chromad enabled devices.

BUG=chromium:713709
R=asanka@chromium.org,rsleevi@chromium.org
==========

[zentaro, 2017-05-08 19:07:45]

zentaro@chromium.org changed reviewers:
+ asanka@chromium.org
- asanka (out until may 22);rsleevi@chromium.org

[zentaro, 2017-05-08 19:08:50]

zentaro@chromium.org changed reviewers:
+ rsleevi@chromium.org

[zentaro, 2017-05-08 19:09:38]

On 2017/05/08 15:38:26, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

rsleevi@ - Asanka already LGTM'd but he isn't an owner of io_thread.* Could you
PTAL.

Thanks!

[Ryan Sleevi, 2017-05-08 21:53:27]

lgtm

[zentaro, 2017-05-09 13:07:29]

The CQ bit was checked by zentaro@chromium.org

[commit-bot: I haz the power, 2017-05-09 13:07:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 13:11:54]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494335249308850,
"parent_rev": "dba25668458c87c4b38c63db710c49c47d0db087", "commit_rev":
"e03263581463ff17960eef46c3173bb28d9e3b8e"}

[commit-bot: I haz the power, 2017-05-09 13:12:02]

Description was changed from

==========
Enable loading gssapi library for Chromad.

This enables building in Kerberos/gssapi support on Chrome OS
but only loads the library for Chromad enabled devices.

BUG=chromium:713709
R=asanka@chromium.org,rsleevi@chromium.org
==========

to

==========
Enable loading gssapi library for Chromad.

This enables building in Kerberos/gssapi support on Chrome OS
but only loads the library for Chromad enabled devices.

BUG=chromium:713709
R=asanka@chromium.org,rsleevi@chromium.org

Review-Url: https://codereview.chromium.org/2826273004
Cr-Commit-Position: refs/heads/master@{#470303}
Committed:
https://chromium.googlesource.com/chromium/src/+/e03263581463ff17960eef46c317...
==========

[commit-bot: I haz the power, 2017-05-09 13:12:03]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e03263581463ff17960eef46c317...