dtrainor@chromium.org: chrome/android/javatests bshe@chromium.org: third_party/gvr-android-sdk DEPS, .gitignore, and the chrome/test/data/android/ change are owned by both of ...
3 years, 8 months ago
(2017-04-19 20:23:27 UTC)
#2
dtrainor@chromium.org: chrome/android/javatests
bshe@chromium.org: third_party/gvr-android-sdk
DEPS, .gitignore, and the chrome/test/data/android/ change are owned by both of
you, so one of you PTAL at those, as well.
bshe
https://codereview.chromium.org/2826273002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java File chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java (right): https://codereview.chromium.org/2826273002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java#newcode42 chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java:42: public void toggleTouchpadButton() { Doesn't look like this function ...
3 years, 8 months ago
(2017-04-20 20:23:13 UTC)
#3
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/162802)
3 years, 8 months ago
(2017-04-21 19:01:16 UTC)
#10
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/162905)
3 years, 8 months ago
(2017-04-21 21:51:45 UTC)
#15
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/202313)
3 years, 8 months ago
(2017-04-26 19:00:17 UTC)
#20
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493233282642440, "parent_rev": "a38b0559bbdd200948efbe9b7a2a2d13c91081c3", "commit_rev": "62d159fb42542807142a39033744c73bbb506698"}
3 years, 8 months ago
(2017-04-26 19:59:07 UTC)
#23
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493233282642440,
"parent_rev": "a38b0559bbdd200948efbe9b7a2a2d13c91081c3", "commit_rev":
"62d159fb42542807142a39033744c73bbb506698"}
commit-bot: I haz the power
Description was changed from ========== Add automated VR controller emulator Adds the Daydream controller test ...
3 years, 8 months ago
(2017-04-26 19:59:18 UTC)
#24
Message was sent while issue was closed.
Description was changed from
==========
Add automated VR controller emulator
Adds the Daydream controller test API, includes it in the test APK,
and adds a simple WebVR test using it. The wrapper around the API
will be further improved in the future once VR Shell testing becomes
the focus - for now, it only supports clicking of the touchpad button.
BUG=713342
==========
to
==========
Add automated VR controller emulator
Adds the Daydream controller test API, includes it in the test APK,
and adds a simple WebVR test using it. The wrapper around the API
will be further improved in the future once VR Shell testing becomes
the focus - for now, it only supports clicking of the touchpad button.
BUG=713342
Review-Url: https://codereview.chromium.org/2826273002
Cr-Commit-Position: refs/heads/master@{#467420}
Committed:
https://chromium.googlesource.com/chromium/src/+/62d159fb42542807142a39033744...
==========
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/62d159fb42542807142a39033744c73bbb506698
3 years, 8 months ago
(2017-04-26 19:59:19 UTC)
#25
Issue 2826273002: Add automated VR controller emulator
(Closed)
Created 3 years, 8 months ago by bsheedy
Modified 3 years, 8 months ago
Reviewers: David Trainor- moved to gerrit, bshe
Base URL:
Comments: 2