Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2826273002: Add automated VR controller emulator (Closed)

Created:
3 years, 8 months ago by bsheedy
Modified:
3 years, 8 months ago
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add automated VR controller emulator Adds the Daydream controller test API, includes it in the test APK, and adds a simple WebVR test using it. The wrapper around the API will be further improved in the future once VR Shell testing becomes the focus - for now, it only supports clicking of the touchpad button. BUG=713342 Review-Url: https://codereview.chromium.org/2826273002 Cr-Commit-Position: refs/heads/master@{#467420} Committed: https://chromium.googlesource.com/chromium/src/+/62d159fb42542807142a39033744c73bbb506698

Patch Set 1 #

Patch Set 2 : Move library to test subdirectory #

Total comments: 2

Patch Set 3 : Remove unused method #

Patch Set 4 : Re-add LargeTest import #

Patch Set 5 : New library version + proguard config #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -42 lines) Patch
M DEPS View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java View 1 2 3 4 2 chunks +21 lines, -1 line 0 comments Download
M chrome/android/shared_preference_files/test/vr_ddview_skipdon_setupcomplete.json View 1 chunk +4 lines, -1 line 0 comments Download
A + chrome/test/data/android/webvr_instrumentation/html/test_screen_taps_registered.html View 2 chunks +4 lines, -3 lines 0 comments Download
D chrome/test/data/android/webvr_instrumentation/html/test_screen_taps_registered_on_cardboard.html View 1 chunk +0 lines, -37 lines 0 comments Download
M third_party/.gitignore View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/gvr-android-sdk/BUILD.gn View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/gvr-android-sdk/README.chromium View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/gvr-android-sdk/test-libraries/controller_test_api.aar.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/gvr-android-sdk/test-libraries/proguard.txt View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
bsheedy
dtrainor@chromium.org: chrome/android/javatests bshe@chromium.org: third_party/gvr-android-sdk DEPS, .gitignore, and the chrome/test/data/android/ change are owned by both of ...
3 years, 8 months ago (2017-04-19 20:23:27 UTC) #2
bshe
https://codereview.chromium.org/2826273002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java File chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java (right): https://codereview.chromium.org/2826273002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java#newcode42 chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java:42: public void toggleTouchpadButton() { Doesn't look like this function ...
3 years, 8 months ago (2017-04-20 20:23:13 UTC) #3
bsheedy
https://codereview.chromium.org/2826273002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java File chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java (right): https://codereview.chromium.org/2826273002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java#newcode42 chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java:42: public void toggleTouchpadButton() { On 2017/04/20 20:23:13, bshe wrote: ...
3 years, 8 months ago (2017-04-21 16:35:33 UTC) #4
David Trainor- moved to gerrit
chrome/android lgtm
3 years, 8 months ago (2017-04-21 16:56:03 UTC) #5
bshe
On 2017/04/21 16:56:03, David Trainor-ping if over 24h wrote: > chrome/android lgtm lgtm
3 years, 8 months ago (2017-04-21 17:57:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826273002/40001
3 years, 8 months ago (2017-04-21 18:06:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/162802)
3 years, 8 months ago (2017-04-21 19:01:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826273002/60001
3 years, 8 months ago (2017-04-21 20:44:35 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/162905)
3 years, 8 months ago (2017-04-21 21:51:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826273002/80001
3 years, 8 months ago (2017-04-26 17:31:18 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/202313)
3 years, 8 months ago (2017-04-26 19:00:17 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826273002/80001
3 years, 8 months ago (2017-04-26 19:02:00 UTC) #22
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 19:59:19 UTC) #25
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/62d159fb42542807142a39033744...

Powered by Google App Engine
This is Rietveld 408576698