Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2826253002:
Add fieldtrial_testing_config for parallel downloading. (Closed)
|
Created:
3 years, 8 months ago by xingliu Modified:
3 years, 8 months ago Reviewers:
Alexei Svitkine (slow) CC:
chromium-reviews, David Trainor- moved to gerrit, qinmin Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd fieldtrial_testing_config for parallel downloading.
This is needed for beta finch config.
BUG=644352
Review-Url: https://codereview.chromium.org/2826253002
Cr-Commit-Position: refs/heads/master@{#465796}
Committed: https://chromium.googlesource.com/chromium/src/+/a022d09fac4eae6cadf496a3f743488bbb60dafd
Patch Set 1 #
Total comments: 2
Patch Set 2 : Match the config to beta finch config. #Messages
Total messages: 23 (14 generated)
Description was changed from ========== Add fieldtrial_testing_config for parallel downloading. This is needed for beta finch config. This CL doesn't specify enable_features since most of the download test is designed for non-parallel. BUG=644352 ========== to ========== Add fieldtrial_testing_config for parallel downloading. This is needed for beta finch config. This CL doesn't specify enable_features since most of the download test is designed for non-parallel download. And parallel download is used only under certain criteria. BUG=644352 ==========
xingliu@chromium.org changed reviewers: + asvitkine@chromium.org
Hi, PTAL, thanks. Added this config for the finch config on beta channel. In here I ran into an error that guides me to do this: https://critique.corp.google.com/#review/153617446/depot/google3/googledata/g...
https://codereview.chromium.org/2826253002/diff/1/testing/variations/fieldtri... File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2826253002/diff/1/testing/variations/fieldtri... testing/variations/fieldtrial_testing_config.json:1790: ] You're missing enable_features and params sections. You'll need these to match your beta configs or you'll get warnings about that.
The CQ bit was checked by xingliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks for the review. Do we need to make sure all browser tests passed when the feature is enabled? https://codereview.chromium.org/2826253002/diff/1/testing/variations/fieldtri... File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2826253002/diff/1/testing/variations/fieldtri... testing/variations/fieldtrial_testing_config.json:1790: ] On 2017/04/19 19:56:21, Alexei Svitkine (slow) wrote: > You're missing enable_features and params sections. > > You'll need these to match your beta configs or you'll get warnings about that. Done.
Description was changed from ========== Add fieldtrial_testing_config for parallel downloading. This is needed for beta finch config. This CL doesn't specify enable_features since most of the download test is designed for non-parallel download. And parallel download is used only under certain criteria. BUG=644352 ========== to ========== Add fieldtrial_testing_config for parallel downloading. This is needed for beta finch config. https://critique.corp.google.com/#review/153617446/depot/google3/googledata/g... BUG=644352 ==========
Description was changed from ========== Add fieldtrial_testing_config for parallel downloading. This is needed for beta finch config. https://critique.corp.google.com/#review/153617446/depot/google3/googledata/g... BUG=644352 ========== to ========== Add fieldtrial_testing_config for parallel downloading. This is needed for beta finch config. BUG=644352 ==========
On 2017/04/19 20:54:23, xingliu wrote: > Thanks for the review. Do we need to make sure all browser tests passed when the > feature is enabled? > Yes, that's the idea. We don't want to be shipping features that break functionality. > https://codereview.chromium.org/2826253002/diff/1/testing/variations/fieldtri... > File testing/variations/fieldtrial_testing_config.json (right): > > https://codereview.chromium.org/2826253002/diff/1/testing/variations/fieldtri... > testing/variations/fieldtrial_testing_config.json:1790: ] > On 2017/04/19 19:56:21, Alexei Svitkine (slow) wrote: > > You're missing enable_features and params sections. > > > > You'll need these to match your beta configs or you'll get warnings about > that. > > Done.
lgtm assuming tests pass
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks!
The CQ bit was checked by xingliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by xingliu@chromium.org
The CQ bit was checked by xingliu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492642295528840,
"parent_rev": "b8a8a089caa1188776c83e4344df494d6f30b969", "commit_rev":
"a022d09fac4eae6cadf496a3f743488bbb60dafd"}
Message was sent while issue was closed.
Description was changed from ========== Add fieldtrial_testing_config for parallel downloading. This is needed for beta finch config. BUG=644352 ========== to ========== Add fieldtrial_testing_config for parallel downloading. This is needed for beta finch config. BUG=644352 Review-Url: https://codereview.chromium.org/2826253002 Cr-Commit-Position: refs/heads/master@{#465796} Committed: https://chromium.googlesource.com/chromium/src/+/a022d09fac4eae6cadf496a3f743... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a022d09fac4eae6cadf496a3f743...
Message was sent while issue was closed.
It seems the experiment in fieldtrial_testing_config.json is only applied to chrome browser tests, and have no effects on content browser tests. So I guess we don't need to adjust content download browser tests for now. |
