[turbofan] Graph builder: reuse the one-element cache for parameters state values.

[turbofan] Graph builder: reuse the one-element cache for parameters state values.

Without this fix, we create a new state-values node for parameters per environment. This is especially bad for heavily branching functions. With the fix, we should only create one node per function.

Drive-by: removes some unused fields for state values in the environment.

BUG=v8:5267
Review-Url: https://codereview.chromium.org/2826223004
Cr-Commit-Position: refs/heads/master@{#44744}
Committed: https://chromium.googlesource.com/v8/v8/+/e24206b2fa104965a850e8c1012d64697e65d45a

[Jarin, 2017-04-20 11:44:38]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 11:44:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2017-04-20 11:46:48]

Description was changed from

==========
[turbofan] Graph builder: reuse the one-element cache for parameters state
values.

Drive-by: removes some unused fields in the environment.

BUG=v8:5267
==========

to

==========
[turbofan] Graph builder: reuse the one-element cache for parameters state
values.

Drive-by: removes some unused fields in the environment.

BUG=v8:5267
==========

[Jarin, 2017-04-20 11:46:48]

jarin@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Jarin, 2017-04-20 11:54:30]

Description was changed from

==========
[turbofan] Graph builder: reuse the one-element cache for parameters state
values.

Drive-by: removes some unused fields in the environment.

BUG=v8:5267
==========

to

==========
[turbofan] Graph builder: reuse the one-element cache for parameters state
values.

Without this fix, we create a new state-values node for parameters per
environment. This is especially bad for heavily branching functions. With the
fix, we should only create one node per function.

Drive-by: removes some unused fields for state values in the environment.

BUG=v8:5267
==========

[Jarin, 2017-04-20 11:54:48]

Could you take a look, please?

https://codereview.chromium.org/2826223004/diff/1/src/compiler/bytecode-graph...
File src/compiler/bytecode-graph-builder.cc (right):

https://codereview.chromium.org/2826223004/diff/1/src/compiler/bytecode-graph...
src/compiler/bytecode-graph-builder.cc:163:
parameters_state_values_(other->parameters_state_values_),
This line is the real fix, the rest is drive-by :-)

[commit-bot: I haz the power, 2017-04-20 12:07:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 12:07:53]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2017-04-20 13:07:49]

LGTM.

[Jarin, 2017-04-20 13:09:36]

The CQ bit was checked by jarin@chromium.org

[commit-bot: I haz the power, 2017-04-20 13:09:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 13:11:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492693776762540, "parent_rev":
"3884f608685e9ba8cc6bae31e3b622f1205fe9bc", "commit_rev":
"e24206b2fa104965a850e8c1012d64697e65d45a"}

[commit-bot: I haz the power, 2017-04-20 13:11:21]

Description was changed from

==========
[turbofan] Graph builder: reuse the one-element cache for parameters state
values.

Without this fix, we create a new state-values node for parameters per
environment. This is especially bad for heavily branching functions. With the
fix, we should only create one node per function.

Drive-by: removes some unused fields for state values in the environment.

BUG=v8:5267
==========

to

==========
[turbofan] Graph builder: reuse the one-element cache for parameters state
values.

Without this fix, we create a new state-values node for parameters per
environment. This is especially bad for heavily branching functions. With the
fix, we should only create one node per function.

Drive-by: removes some unused fields for state values in the environment.

BUG=v8:5267

Review-Url: https://codereview.chromium.org/2826223004
Cr-Commit-Position: refs/heads/master@{#44744}
Committed:
https://chromium.googlesource.com/v8/v8/+/e24206b2fa104965a850e8c1012d64697e6...
==========

[commit-bot: I haz the power, 2017-04-20 13:11:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e24206b2fa104965a850e8c1012d64697e6...