Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2826203002: Use SameDocument term instead of SamePage in android media tests. (Closed)

Created:
3 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 8 months ago
Reviewers:
aberent, whywhat
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SameDocument term instead of SamePage in android media tests. Old name was presumably used to match was_within_same_page IPC, but SameDocument name better reflects the the type of the navigation (navigation did not change the document object). This change will make naming more consistent with the rest of Chromium code. BUG=695189 Review-Url: https://codereview.chromium.org/2826203002 Cr-Commit-Position: refs/heads/master@{#466410} Committed: https://chromium.googlesource.com/chromium/src/+/c51f182ce2d04ed0d4a24279fe06651f805e22a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTestUtils.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Eugene But (OOO till 7-30)
3 years, 8 months ago (2017-04-19 18:23:13 UTC) #4
Eugene But (OOO till 7-30)
On 2017/04/19 18:23:13, Eugene But wrote: Ping
3 years, 8 months ago (2017-04-20 18:44:30 UTC) #7
Eugene But (OOO till 7-30)
3 years, 8 months ago (2017-04-21 17:01:58 UTC) #9
whywhat
lgtm lgtm
3 years, 8 months ago (2017-04-21 18:14:59 UTC) #10
Eugene But (OOO till 7-30)
Thanks for quick review!
3 years, 8 months ago (2017-04-21 18:49:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826203002/1
3 years, 8 months ago (2017-04-21 18:50:18 UTC) #13
whywhat
On 2017/04/21 at 18:49:51, eugenebut wrote: > Thanks for quick review! I meant to say ...
3 years, 8 months ago (2017-04-21 18:53:42 UTC) #14
Eugene But (OOO till 7-30)
On 2017/04/21 18:53:42, whywhat wrote: > On 2017/04/21 at 18:49:51, eugenebut wrote: > > Thanks ...
3 years, 8 months ago (2017-04-21 18:56:01 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 19:19:46 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c51f182ce2d04ed0d4a24279fe06...

Powered by Google App Engine
This is Rietveld 408576698