Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issue 2826183002: [inspector] collect old async stack traces 20% faster (Closed)

Created:
3 years, 8 months ago by kozy
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] collect old async stack traces 20% faster BUG=v8:6189 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2826183002 Cr-Commit-Position: refs/heads/master@{#44755} Committed: https://chromium.googlesource.com/v8/v8/+/296be5222d74acd61ea10894b06690016acaf582

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -27 lines) Patch
M src/inspector/v8-debugger.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/inspector/v8-debugger.cc View 1 2 chunks +25 lines, -26 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
kozy
Dmitry, please take a look.
3 years, 8 months ago (2017-04-19 17:58:04 UTC) #1
dgozman
Interesting how this is faster... lgtm
3 years, 8 months ago (2017-04-19 20:30:13 UTC) #2
kozy
On 2017/04/19 20:30:13, dgozman wrote: > Interesting how this is faster... > > lgtm copying ...
3 years, 8 months ago (2017-04-20 00:12:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826183002/40001
3 years, 8 months ago (2017-04-20 17:43:17 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 18:07:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/296be5222d74acd61ea10894b06690016ac...

Powered by Google App Engine
This is Rietveld 408576698