DevTools: prepare Navigator and Network Project for merging uiSourceCodes

DevTools: prepare Navigator and Network Project for merging uiSourceCodes

The crrev.com/2714053002/, which implemented UISourceCode merging, didn't handle
removal of source map source files (they were never removed back in the days).

Since now we do all the bookkeeping properly, that CL should be
complicated further, which makes it uncomfortably large.

This patch extracts a few important bits from that CL, making future
patches simpler.

This patch:
- introduces NewtorkProject.frameAttribution method which returns frameIds
  for the UISourceCode.
- implements shortcuts in NavigatorView, using NetworkProject.frameAttribution
- improves NetworkProject to fetch resource metadatas efficiently

BUG=670180
R=dgozman

Review-Url: https://codereview.chromium.org/2826173003
Cr-Commit-Position: refs/heads/master@{#466492}
Committed: https://chromium.googlesource.com/chromium/src/+/8d63b4e145b185c53bd013b592c6c80b4e6365c4

[lushnikov, 2017-04-20 00:04:44]

Description was changed from

==========
DevTools: prepare Navigator for merging uiSourceCodes inside target

This patch prepares Navigator view for merging uiSourceCodes. This patch
is a part of crrev.com/2714053002/.

BUG=670180
R=dgozman
==========

to

==========
DevTools: prepare Navigator and Network Project for merging uiSourceCodes

The crrev.com/2714053002/, which implemented UISourceCode merging, didn't handle
removal of source map source files (they were never removed back in the days).

Since now we do all the bookkeeping properly, that CL has to be improved,
which makes it uncomfortably large.

This patch extracts a few important bits from that CL, making future
patches simpler.

This patch:
- prepares navigator view for the multiple frame ids per UISourceCode
- improves NetworkProject to fetch resource metadatas efficiently

BUG=670180
R=dgozman
==========

[lushnikov, 2017-04-20 00:05:20]

Description was changed from

==========
DevTools: prepare Navigator and Network Project for merging uiSourceCodes

The crrev.com/2714053002/, which implemented UISourceCode merging, didn't handle
removal of source map source files (they were never removed back in the days).

Since now we do all the bookkeeping properly, that CL has to be improved,
which makes it uncomfortably large.

This patch extracts a few important bits from that CL, making future
patches simpler.

This patch:
- prepares navigator view for the multiple frame ids per UISourceCode
- improves NetworkProject to fetch resource metadatas efficiently

BUG=670180
R=dgozman
==========

to

==========
DevTools: prepare Navigator and Network Project for merging uiSourceCodes

The crrev.com/2714053002/, which implemented UISourceCode merging, didn't handle
removal of source map source files (they were never removed back in the days).

Since now we do all the bookkeeping properly, that CL should be
complicated further, which makes it uncomfortably large.

This patch extracts a few important bits from that CL, making future
patches simpler.

This patch:
- prepares navigator view for the multiple frame ids per UISourceCode
- improves NetworkProject to fetch resource metadatas efficiently

BUG=670180
R=dgozman
==========

[lushnikov, 2017-04-20 00:05:28]

please, take a look

[lushnikov, 2017-04-20 00:05:34]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 00:06:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2017-04-20 00:26:30]

Description was changed from

==========
DevTools: prepare Navigator and Network Project for merging uiSourceCodes

The crrev.com/2714053002/, which implemented UISourceCode merging, didn't handle
removal of source map source files (they were never removed back in the days).

Since now we do all the bookkeeping properly, that CL should be
complicated further, which makes it uncomfortably large.

This patch extracts a few important bits from that CL, making future
patches simpler.

This patch:
- prepares navigator view for the multiple frame ids per UISourceCode
- improves NetworkProject to fetch resource metadatas efficiently

BUG=670180
R=dgozman
==========

to

==========
DevTools: prepare Navigator and Network Project for merging uiSourceCodes

The crrev.com/2714053002/, which implemented UISourceCode merging, didn't handle
removal of source map source files (they were never removed back in the days).

Since now we do all the bookkeeping properly, that CL should be
complicated further, which makes it uncomfortably large.

This patch extracts a few important bits from that CL, making future
patches simpler.

This patch:
- introduces NewtorkProject.frameAttribution method which returns frameIds
  for the UISourceCode.
- implements shortcuts in NavigatorView, using NetworkProject.frameAttribution
- improves NetworkProject to fetch resource metadatas efficiently

BUG=670180
R=dgozman
==========

[lushnikov, 2017-04-20 00:26:37]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 00:27:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 02:05:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 02:05:41]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-04-20 17:12:07]

https://codereview.chromium.org/2826173003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js
(right):

https://codereview.chromium.org/2826173003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js:433: var
resource = frame ? frame.resourceForURL(url) :
this._resourceTreeModel.resourceForURL(url);
Why second part here? It's either from the frame or none!

https://codereview.chromium.org/2826173003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
(right):

https://codereview.chromium.org/2826173003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:256:
frames = Array.from(frameIds).map(frameId =>
resourceTreeModel.frameForId(frameId));
Let's make NetworkProject do the mapping and return frame objects.

https://codereview.chromium.org/2826173003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:287: if
(frames && frames.length) {
frames are never empty.

[lushnikov, 2017-04-21 01:21:51]

please, take another look!

https://codereview.chromium.org/2826173003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js
(right):

https://codereview.chromium.org/2826173003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js:433: var
resource = frame ? frame.resourceForURL(url) :
this._resourceTreeModel.resourceForURL(url);
On 2017/04/20 17:12:07, dgozman wrote:
> Why second part here? It's either from the frame or none!

Nailed it.

https://codereview.chromium.org/2826173003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
(right):

https://codereview.chromium.org/2826173003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:256:
frames = Array.from(frameIds).map(frameId =>
resourceTreeModel.frameForId(frameId));
On 2017/04/20 17:12:07, dgozman wrote:
> Let's make NetworkProject do the mapping and return frame objects.

Done.

https://codereview.chromium.org/2826173003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js:287: if
(frames && frames.length) {
On 2017/04/20 17:12:07, dgozman wrote:
> frames are never empty.

Done.

[lushnikov, 2017-04-21 01:21:58]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 01:22:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 02:54:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 02:54:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2017-04-21 22:25:24]

lgtm

[lushnikov, 2017-04-21 22:55:48]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-04-21 22:56:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 23:37:04]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492815348266620,
"parent_rev": "5cd3126fe5f3a66e8e2fd0f134e3ec3caaab9f87", "commit_rev":
"8d63b4e145b185c53bd013b592c6c80b4e6365c4"}

[commit-bot: I haz the power, 2017-04-21 23:37:16]

Description was changed from

==========
DevTools: prepare Navigator and Network Project for merging uiSourceCodes

The crrev.com/2714053002/, which implemented UISourceCode merging, didn't handle
removal of source map source files (they were never removed back in the days).

Since now we do all the bookkeeping properly, that CL should be
complicated further, which makes it uncomfortably large.

This patch extracts a few important bits from that CL, making future
patches simpler.

This patch:
- introduces NewtorkProject.frameAttribution method which returns frameIds
  for the UISourceCode.
- implements shortcuts in NavigatorView, using NetworkProject.frameAttribution
- improves NetworkProject to fetch resource metadatas efficiently

BUG=670180
R=dgozman
==========

to

==========
DevTools: prepare Navigator and Network Project for merging uiSourceCodes

The crrev.com/2714053002/, which implemented UISourceCode merging, didn't handle
removal of source map source files (they were never removed back in the days).

Since now we do all the bookkeeping properly, that CL should be
complicated further, which makes it uncomfortably large.

This patch extracts a few important bits from that CL, making future
patches simpler.

This patch:
- introduces NewtorkProject.frameAttribution method which returns frameIds
  for the UISourceCode.
- implements shortcuts in NavigatorView, using NetworkProject.frameAttribution
- improves NetworkProject to fetch resource metadatas efficiently

BUG=670180
R=dgozman

Review-Url: https://codereview.chromium.org/2826173003
Cr-Commit-Position: refs/heads/master@{#466492}
Committed:
https://chromium.googlesource.com/chromium/src/+/8d63b4e145b185c53bd013b592c6...
==========

[commit-bot: I haz the power, 2017-04-21 23:37:17]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8d63b4e145b185c53bd013b592c6...