Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2826123003: Pushing back rtcpMuxPolicy deprecation message to M62. (Closed)

Created:
3 years, 8 months ago by Taylor_Brandstetter
Modified:
3 years, 8 months ago
Reviewers:
foolip
CC:
chromium-reviews, blink-reviews, blink-reviews-frames_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pushing back rtcpMuxPolicy deprecation message to M62. Since originally adding this deprecation message, we heard from the Asterisk community (which would be affected by this change), and believe that M62 will give enough time for users who use "modern branches" of Asterisk to upgrade to a new version that supports RTCP muxing. See discussion here: https://groups.google.com/a/chromium.org/d/msg/blink-dev/OP2SGSWF5lo/v7GOaWt_CQAJ BUG=chromium:685727 Review-Url: https://codereview.chromium.org/2826123003 Cr-Commit-Position: refs/heads/master@{#466163} Committed: https://chromium.googlesource.com/chromium/src/+/0c12d093e94c924034f682abe7e7f643453fd28c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Updating deprecation message in layout test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Taylor_Brandstetter
PTAL
3 years, 8 months ago (2017-04-19 23:51:13 UTC) #2
foolip
lgtm https://codereview.chromium.org/2826123003/diff/1/third_party/WebKit/Source/core/frame/Deprecation.cpp File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/2826123003/diff/1/third_party/WebKit/Source/core/frame/Deprecation.cpp#newcode23 third_party/WebKit/Source/core/frame/Deprecation.cpp:23: M61, If you rebase this should disappear, but ...
3 years, 8 months ago (2017-04-20 09:53:50 UTC) #3
Taylor_Brandstetter
https://codereview.chromium.org/2826123003/diff/1/third_party/WebKit/Source/core/frame/Deprecation.cpp File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/2826123003/diff/1/third_party/WebKit/Source/core/frame/Deprecation.cpp#newcode23 third_party/WebKit/Source/core/frame/Deprecation.cpp:23: M61, On 2017/04/20 09:53:50, foolip_UTC7 wrote: > If you ...
3 years, 8 months ago (2017-04-20 20:33:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826123003/40001
3 years, 8 months ago (2017-04-20 20:38:22 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 22:23:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0c12d093e94c924034f682abe7e7...

Powered by Google App Engine
This is Rietveld 408576698