Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2826113002: Remove use_qualified_include from grit_rule.gni (Closed)

Created:
3 years, 8 months ago by Nico
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove use_qualified_include from grit_rule.gni Only one target (somewhat questionably) still uses this, so just set the include directory in that target directly. BUG=401588 TBR=brettw Review-Url: https://codereview.chromium.org/2826113002 Cr-Commit-Position: refs/heads/master@{#465643} Committed: https://chromium.googlesource.com/chromium/src/+/f1ddb6a06f9696e0c613abcfab1cb5d5e2e7869d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M third_party/libaddressinput/BUILD.gn View 1 chunk +4 lines, -3 lines 0 comments Download
M tools/grit/grit_rule.gni View 2 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Nico
brettw: grit_rule.gni rouslan: libaddressinput
3 years, 8 months ago (2017-04-19 15:21:21 UTC) #4
please use gerrit instead
lgtm
3 years, 8 months ago (2017-04-19 16:05:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826113002/1
3 years, 8 months ago (2017-04-19 16:55:47 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 17:03:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f1ddb6a06f9696e0c613abcfab1c...

Powered by Google App Engine
This is Rietveld 408576698