Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2826073003: [ObjC ARC] Converts ios/chrome/browser/ui/toolbar:test_support to ARC. (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/toolbar:test_support to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2826073003 Cr-Commit-Position: refs/heads/master@{#466957} Committed: https://chromium.googlesource.com/chromium/src/+/bfbf87d97979e6a32080320bd5ade308b7a1844a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change FALSE to false #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M ios/chrome/browser/ui/toolbar/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/test_toolbar_model_ios.mm View 1 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
gambard
PTAL.
3 years, 8 months ago (2017-04-20 08:03:33 UTC) #4
rohitrao (ping after 24h)
lgtm https://codereview.chromium.org/2826073003/diff/1/ios/chrome/browser/ui/toolbar/test_toolbar_model_ios.mm File ios/chrome/browser/ui/toolbar/test_toolbar_model_ios.mm (right): https://codereview.chromium.org/2826073003/diff/1/ios/chrome/browser/ui/toolbar/test_toolbar_model_ios.mm#newcode16 ios/chrome/browser/ui/toolbar/test_toolbar_model_ios.mm:16: is_loading_(FALSE), These should be false instead of FALSE, ...
3 years, 8 months ago (2017-04-25 06:44:12 UTC) #7
gambard
Thanks! https://codereview.chromium.org/2826073003/diff/1/ios/chrome/browser/ui/toolbar/test_toolbar_model_ios.mm File ios/chrome/browser/ui/toolbar/test_toolbar_model_ios.mm (right): https://codereview.chromium.org/2826073003/diff/1/ios/chrome/browser/ui/toolbar/test_toolbar_model_ios.mm#newcode16 ios/chrome/browser/ui/toolbar/test_toolbar_model_ios.mm:16: is_loading_(FALSE), On 2017/04/25 06:44:12, rohitrao wrote: > These ...
3 years, 8 months ago (2017-04-25 11:37:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826073003/20001
3 years, 8 months ago (2017-04-25 11:38:27 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 12:49:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bfbf87d97979e6a32080320bd5ad...

Powered by Google App Engine
This is Rietveld 408576698