Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc

Issue 2826043002: Do not share FBOs/VAOs/Transform feedback objects across contexts (Closed)
Patch Set: added DeleteFramebuffers() expectation Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
index d913f37c53ef0927dc5c6b56b4bd58a278c9cb7a..a5b0812c8b3af51169b05143ecbbb8854dada4f3 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
@@ -542,6 +542,7 @@ void GLES2DecoderTestBase::ResetDecoder() {
EXPECT_EQ(GL_NO_ERROR, GetGLError());
if (!decoder_->WasContextLost()) {
EXPECT_CALL(*gl_, DeleteBuffersARB(1, _)).Times(2).RetiresOnSaturation();
+ EXPECT_CALL(*gl_, DeleteFramebuffersEXT(1, _)).Times(AnyNumber());
Chandan 2017/05/18 13:33:36 The no. of DeleteFramebuffers calls possible here
Zhenyao Mo 2017/05/18 17:39:53 If you set it to Times(1).RetiresOnSaturation(), a
Chandan 2017/05/18 18:10:09 Yes, around 24 tests were failing for the reason t
if (group_->feature_info()->feature_flags().native_vertex_array_object) {
EXPECT_CALL(*gl_,
DeleteVertexArraysOES(1, Pointee(kServiceVertexArrayId)))

Powered by Google App Engine
This is Rietveld 408576698