Do not share FBOs/VAOs/Transform feedback objects across contexts

gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 524 matching lines @@
   EXPECT_EQ(GL_NO_ERROR, GetGLError());
 }
 
 void GLES2DecoderTestBase::ResetDecoder() {
   if (!decoder_.get())
     return;
   // All Tests should have read all their GLErrors before getting here.
   EXPECT_EQ(GL_NO_ERROR, GetGLError());
   if (!decoder_->WasContextLost()) {
     EXPECT_CALL(*gl_, DeleteBuffersARB(1, _)).Times(2).RetiresOnSaturation();
+    EXPECT_CALL(*gl_, DeleteFramebuffersEXT(1, _)).Times(AnyNumber());

[Chandan, 2017/05/18 13:33:36]

The no. of DeleteFramebuffers calls possible here is equal to the size of the
framebuffers_ map in FramebufferManager at the time of its destruction i.e. when
the map is cleared, which can be >=0. Therefore, I have added AnyNumber() as the
cardinality here.

[Zhenyao Mo, 2017/05/18 17:39:53]

If you set it to Times(1).RetiresOnSaturation(), are any tests failing?  If not,
I'd prefer that.  AnyNumber() is too allowing, so usually we avoid doing that if
we can.

[Chandan, 2017/05/18 18:10:09]

Yes, around 24 tests were failing for the reason that I have mentioned above.
For some test cases, no. of DeleteFramebuffers calls from
FramebufferManager::Destroy() was 0 since |framebuffers_| map size was 0. For
some it was 1 and for some it was 2. Therefore, Times(1).RetiresOnSaturation()
didn't help.

     if (group_->feature_info()->feature_flags().native_vertex_array_object) {
       EXPECT_CALL(*gl_,
                   DeleteVertexArraysOES(1, Pointee(kServiceVertexArrayId)))
           .Times(1)
           .RetiresOnSaturation();
     }
     if (group_->feature_info()->IsWebGL2OrES3Context()) {
       // fake default transform feedback.
       EXPECT_CALL(*gl_, DeleteTransformFeedbacks(1, _))
           .Times(1)
@@ skipping 1613 matching lines @@
   SetupDefaultProgram();
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "gpu/command_buffer/service/gles2_cmd_decoder_unittest_0_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu