gpu/command_buffer/service/context_group_unittest.cc - Issue 2826043002: Do not share FBOs/VAOs/Transform feedback objects across contexts

Unified Diff: gpu/command_buffer/service/context_group_unittest.cc

Issue 2826043002: Do not share FBOs/VAOs/Transform feedback objects across contexts (Closed)

Patch Set: added DeleteFramebuffers() expectation Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « gpu/command_buffer/service/context_group.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder.h » ('j') | gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/context_group_unittest.cc

diff --git a/gpu/command_buffer/service/context_group_unittest.cc b/gpu/command_buffer/service/context_group_unittest.cc

index d332dc4cd27740ed8931bd3befe363c1ec362c73..88f9fb53df6bd20a19f1bc331d1a0b4c58af0671 100644

--- a/gpu/command_buffer/service/context_group_unittest.cc

+++ b/gpu/command_buffer/service/context_group_unittest.cc

@@ -62,7 +62,6 @@ TEST_F(ContextGroupTest, Basic) {

EXPECT_EQ(0u, group_->max_varying_vectors());

EXPECT_EQ(0u, group_->max_vertex_uniform_vectors());

EXPECT_TRUE(group_->buffer_manager() == NULL);

- EXPECT_TRUE(group_->framebuffer_manager() == NULL);

EXPECT_TRUE(group_->renderbuffer_manager() == NULL);

EXPECT_TRUE(group_->texture_manager() == NULL);

EXPECT_TRUE(group_->program_manager() == NULL);

@@ -90,7 +89,6 @@ TEST_F(ContextGroupTest, InitializeNoExtensions) {

EXPECT_EQ(static_cast<uint32_t>(TestHelper::kMaxVertexUniformVectors),

group_->max_vertex_uniform_vectors());

EXPECT_TRUE(group_->buffer_manager() != NULL);

- EXPECT_TRUE(group_->framebuffer_manager() != NULL);

EXPECT_TRUE(group_->renderbuffer_manager() != NULL);

EXPECT_TRUE(group_->texture_manager() != NULL);

EXPECT_TRUE(group_->program_manager() != NULL);

@@ -98,7 +96,6 @@ TEST_F(ContextGroupTest, InitializeNoExtensions) {

group_->Destroy(decoder_.get(), false);

EXPECT_TRUE(group_->buffer_manager() == NULL);

- EXPECT_TRUE(group_->framebuffer_manager() == NULL);

EXPECT_TRUE(group_->renderbuffer_manager() == NULL);

EXPECT_TRUE(group_->texture_manager() == NULL);

EXPECT_TRUE(group_->program_manager() == NULL);

@@ -122,7 +119,6 @@ TEST_F(ContextGroupTest, MultipleContexts) {

DisallowedFeatures()));

EXPECT_TRUE(group_->buffer_manager() != NULL);

- EXPECT_TRUE(group_->framebuffer_manager() != NULL);

EXPECT_TRUE(group_->renderbuffer_manager() != NULL);

EXPECT_TRUE(group_->texture_manager() != NULL);

EXPECT_TRUE(group_->program_manager() != NULL);

@@ -131,7 +127,6 @@ TEST_F(ContextGroupTest, MultipleContexts) {

group_->Destroy(decoder_.get(), false);

EXPECT_TRUE(group_->buffer_manager() != NULL);

- EXPECT_TRUE(group_->framebuffer_manager() != NULL);

EXPECT_TRUE(group_->renderbuffer_manager() != NULL);

EXPECT_TRUE(group_->texture_manager() != NULL);

EXPECT_TRUE(group_->program_manager() != NULL);

@@ -140,7 +135,6 @@ TEST_F(ContextGroupTest, MultipleContexts) {

group_->Destroy(decoder2_.get(), false);

EXPECT_TRUE(group_->buffer_manager() == NULL);

- EXPECT_TRUE(group_->framebuffer_manager() == NULL);

EXPECT_TRUE(group_->renderbuffer_manager() == NULL);

EXPECT_TRUE(group_->texture_manager() == NULL);

EXPECT_TRUE(group_->program_manager() == NULL);