Prevent integer overflows in ANPlusB handling

Prevent integer overflows in ANPlusB handling

BUG=675112
Review-Url: https://codereview.chromium.org/2825993002
Cr-Commit-Position: refs/heads/master@{#470899}
Committed: https://chromium.googlesource.com/chromium/src/+/111fffdac5769c2358cd7e1d272529bbcca41700

[meade_UTC10, 2017-04-19 06:43:12]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 06:43:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 07:18:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 07:18:04]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[meade_UTC10, 2017-04-20 02:48:15]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 02:48:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meade_UTC10, 2017-04-20 02:52:46]

meade@chromium.org changed reviewers:
+ esprehn@chromium.org, nainar@chromium.org

[meade_UTC10, 2017-04-20 02:52:47]

If this seems like deja-vu, it is: https://codereview.chromium.org/2191253002

I made a new CL instead of trying to rebase that super old one... PTAL?

https://codereview.chromium.org/2825993002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp
(right):

https://codereview.chromium.org/2825993002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp:88:
EXPECT_EQ(test_case.a, ab.first);
Note: Changed the order of these because gTest uses expected, actual ordering
for expectations:

EXPECT_EQ(expected, actual)

[commit-bot: I haz the power, 2017-04-20 03:54:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 03:54:46]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nainar, 2017-04-20 06:42:25]

lgtm

[nainar, 2017-04-20 06:42:37]

rs lgtm since I see you fixed esprehn@'s main concern

[rune, 2017-04-20 10:51:46]

rune@opera.com changed reviewers:
+ rune@opera.com

[rune, 2017-04-20 10:51:47]

lgtm with nits

https://codereview.chromium.org/2825993002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp
(right):

https://codereview.chromium.org/2825993002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp:88:
EXPECT_EQ(test_case.a, ab.first);
On 2017/04/20 02:52:47, meade_UTC10 wrote:
> Note: Changed the order of these because gTest uses expected, actual ordering
> for expectations:
> 
> EXPECT_EQ(expected, actual)

Acknowledged.

https://codereview.chromium.org/2825993002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp:129:
EXPECT_STREQ(list.SelectorsText().Ascii().Data(), test_case[1]);
Isn't test_case[1] the expected result here?

https://codereview.chromium.org/2825993002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp:280:
EXPECT_STREQ(list.SelectorsText().Ascii().Data(), test_case[1]);
Isn't test_case[1] the expected result here?

https://codereview.chromium.org/2825993002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp:336:
EXPECT_STREQ(list.SelectorsText().Ascii().Data(), test_case[1]);
Isn't test_case[1] the expected result here?

[meade_UTC10, 2017-05-05 02:48:46]

https://codereview.chromium.org/2825993002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp
(right):

https://codereview.chromium.org/2825993002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp:129:
EXPECT_STREQ(list.SelectorsText().Ascii().Data(), test_case[1]);
On 2017/04/20 10:51:47, rune wrote:
> Isn't test_case[1] the expected result here?

uhh yes, fixed.

https://codereview.chromium.org/2825993002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp:280:
EXPECT_STREQ(list.SelectorsText().Ascii().Data(), test_case[1]);
On 2017/04/20 10:51:47, rune wrote:
> Isn't test_case[1] the expected result here?

Done.

https://codereview.chromium.org/2825993002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp:336:
EXPECT_STREQ(list.SelectorsText().Ascii().Data(), test_case[1]);
On 2017/04/20 10:51:46, rune wrote:
> Isn't test_case[1] the expected result here?

Done.

[meade_UTC10, 2017-05-05 02:48:50]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2017-05-05 02:48:51]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
rune@opera.com
Link to the patchset: https://codereview.chromium.org/2825993002/#ps40001
(title: "Fix formatting")

[commit-bot: I haz the power, 2017-05-05 02:49:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 04:05:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 04:05:18]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[meade_UTC10, 2017-05-11 08:17:05]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2017-05-11 08:17:05]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
rune@opera.com
Link to the patchset: https://codereview.chromium.org/2825993002/#ps60001
(title: "Remove incorrect test - testing input as -1 for unsigned doesn't make
sense")

[commit-bot: I haz the power, 2017-05-11 08:17:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 10:19:19]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494490625315430,
"parent_rev": "f15abc6c912c395a22c2656a39e9d2c46fba70c8", "commit_rev":
"111fffdac5769c2358cd7e1d272529bbcca41700"}

[commit-bot: I haz the power, 2017-05-11 10:19:30]

Description was changed from

==========
Prevent integer overflows in ANPlusB handling

BUG=675112
==========

to

==========
Prevent integer overflows in ANPlusB handling

BUG=675112

Review-Url: https://codereview.chromium.org/2825993002
Cr-Commit-Position: refs/heads/master@{#470899}
Committed:
https://chromium.googlesource.com/chromium/src/+/111fffdac5769c2358cd7e1d2725...
==========

[commit-bot: I haz the power, 2017-05-11 10:19:32]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/111fffdac5769c2358cd7e1d2725...