Do not notify Wayland clients about activation which came from them.

Do not notify Wayland clients about activation which came from them.

If a task is moved to front on Android side, it will send an activation
request to Wayland server, which will activate the window on Chrome
side. This would formerly notify Wayland client (Android) about the
window activation. If the window no longer had focus on Android side,
we'd refocus it unintentionally.

Now if the activation is originally invoked from Android side, we'll
not call the callback.

TEST=CTS passes without flakyness.
BUG=b/34722452

Review-Url: https://codereview.chromium.org/2825923002
Cr-Commit-Position: refs/heads/master@{#465885}
Committed: https://chromium.googlesource.com/chromium/src/+/684e394da09c25aec471f4468211513244131235

[mtomasz, 2017-04-19 02:42:15]

The CQ bit was checked by mtomasz@chromium.org to run a CQ dry run

[mtomasz, 2017-04-19 02:42:30]

Description was changed from

==========
Do not notify Wayland clients about activation which came from them.

If a task is moved to front on Android side, it will send an activation
request to Wayland server, which will activate the window on Chrome
side. This would formerly notify Wayland client (Android) about the
window activation. If the window no longer had focus on Android side,
we'd refocus it unintentionally.

Now if the activation is originally invoked from Android side, we'll
not call the callback.

TEST=CTS passes without flakyness.
BUG=b/34722452
==========

to

==========
Do not notify Wayland clients about activation which came from them.

If a task is moved to front on Android side, it will send an activation
request to Wayland server, which will activate the window on Chrome
side. This would formerly notify Wayland client (Android) about the
window activation. If the window no longer had focus on Android side,
we'd refocus it unintentionally.

Now if the activation is originally invoked from Android side, we'll
not call the callback.

TEST=CTS passes without flakyness.
BUG=b/34722452
==========

[mtomasz, 2017-04-19 02:42:31]

mtomasz@chromium.org changed reviewers:
+ reveman@chromium.org

[commit-bot: I haz the power, 2017-04-19 02:42:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtomasz, 2017-04-19 02:44:49]

@reveman: PTAL. Oshima@ suggested to do this only for ShellSurfaces having
BoundsMode CLIENT to limit to ARC client only. Do any other clients than ARC use
or plan to use zcr_remote_surface_activate?

[commit-bot: I haz the power, 2017-04-19 03:08:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 03:09:00]

Dry run: This issue passed the CQ dry run.

[mtomasz, 2017-04-19 03:57:19]

The CQ bit was checked by mtomasz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 03:57:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtomasz, 2017-04-19 04:08:38]

The CTS is still flaky. Looking at it.

[reveman, 2017-04-19 04:14:13]

lgtm + nits

https://codereview.chromium.org/2825923002/diff/60001/components/exo/wayland/...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2825923002/diff/60001/components/exo/wayland/...
components/exo/wayland/server.cc:163: DEFINE_UI_CLASS_PROPERTY_KEY(bool,
kIsActivatingFromClient, false);
nit: maybe s/kIsActivatingFromClient/kIgnoreWindowActivated/ so the explanation
of this can be limited to remote_surface_activate code

https://codereview.chromium.org/2825923002/diff/60001/components/exo/wayland/...
components/exo/wayland/server.cc:1940:
window->SetProperty(kIsActivatingFromClient, false);
nit: use ClearProperty

[commit-bot: I haz the power, 2017-04-19 04:25:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 04:25:28]

Dry run: This issue passed the CQ dry run.

[mtomasz, 2017-04-20 00:46:17]

https://codereview.chromium.org/2825923002/diff/60001/components/exo/wayland/...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2825923002/diff/60001/components/exo/wayland/...
components/exo/wayland/server.cc:163: DEFINE_UI_CLASS_PROPERTY_KEY(bool,
kIsActivatingFromClient, false);
On 2017/04/19 04:14:13, reveman wrote:
> nit: maybe s/kIsActivatingFromClient/kIgnoreWindowActivated/ so the
explanation
> of this can be limited to remote_surface_activate code

Done.

https://codereview.chromium.org/2825923002/diff/60001/components/exo/wayland/...
components/exo/wayland/server.cc:1940:
window->SetProperty(kIsActivatingFromClient, false);
On 2017/04/19 04:14:13, reveman wrote:
> nit: use ClearProperty

Done.

[mtomasz, 2017-04-20 00:46:40]

The CQ bit was checked by mtomasz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 00:47:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 01:32:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 01:32:52]

Dry run: This issue passed the CQ dry run.

[mtomasz, 2017-04-20 03:14:56]

The CQ bit was checked by mtomasz@chromium.org

[mtomasz, 2017-04-20 03:14:57]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2825923002/#ps80001
(title: "Cleanup.")

[commit-bot: I haz the power, 2017-04-20 03:15:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 03:20:24]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492658096451660,
"parent_rev": "81544b287da1e33806ac095b86a15d717ebfe27c", "commit_rev":
"684e394da09c25aec471f4468211513244131235"}

[commit-bot: I haz the power, 2017-04-20 03:20:46]

Description was changed from

==========
Do not notify Wayland clients about activation which came from them.

If a task is moved to front on Android side, it will send an activation
request to Wayland server, which will activate the window on Chrome
side. This would formerly notify Wayland client (Android) about the
window activation. If the window no longer had focus on Android side,
we'd refocus it unintentionally.

Now if the activation is originally invoked from Android side, we'll
not call the callback.

TEST=CTS passes without flakyness.
BUG=b/34722452
==========

to

==========
Do not notify Wayland clients about activation which came from them.

If a task is moved to front on Android side, it will send an activation
request to Wayland server, which will activate the window on Chrome
side. This would formerly notify Wayland client (Android) about the
window activation. If the window no longer had focus on Android side,
we'd refocus it unintentionally.

Now if the activation is originally invoked from Android side, we'll
not call the callback.

TEST=CTS passes without flakyness.
BUG=b/34722452

Review-Url: https://codereview.chromium.org/2825923002
Cr-Commit-Position: refs/heads/master@{#465885}
Committed:
https://chromium.googlesource.com/chromium/src/+/684e394da09c25aec471f4468211...
==========

[commit-bot: I haz the power, 2017-04-20 03:20:47]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/684e394da09c25aec471f4468211...