Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2825893003: Remove ResourceFetcher::DeadResourceStatsRecorder (Closed)

Created:
3 years, 8 months ago by yhirano
Modified:
3 years, 8 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, asvitkine+watch_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ResourceFetcher::DeadResourceStatsRecorder It was introduced in 2014 to measure how many dead resources are reused. It is not as useful as it used to be because now dead resources are basically evicted from MemoryCache (with some exceptions such as preloaded resources). BUG=None R=clamy@chromium.org, japhet@chromium.org Review-Url: https://codereview.chromium.org/2825893003 Cr-Commit-Position: refs/heads/master@{#466882} Committed: https://chromium.googlesource.com/chromium/src/+/2a1375ebfbf6f242cfacf55b093066a6386ba227

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -57 lines) Patch
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp View 2 chunks +0 lines, -40 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
yhirano
+clamy@ as a metrics owner, +japhet@ as a platform/loader owner
3 years, 8 months ago (2017-04-19 08:52:53 UTC) #5
clamy
On 2017/04/19 08:52:53, yhirano wrote: > +clamy@ as a metrics owner, +japhet@ as a platform/loader ...
3 years, 8 months ago (2017-04-19 15:36:15 UTC) #8
yhirano
On 2017/04/19 15:36:15, clamy wrote: > On 2017/04/19 08:52:53, yhirano wrote: > > +clamy@ as ...
3 years, 8 months ago (2017-04-19 15:52:55 UTC) #9
clamy
metrics lgtm.
3 years, 8 months ago (2017-04-20 17:09:45 UTC) #10
Nate Chapin
lgtm
3 years, 8 months ago (2017-04-21 18:14:52 UTC) #11
yhirano
+isherman@ for histograms.xml
3 years, 8 months ago (2017-04-24 01:41:20 UTC) #13
Ilya Sherman
histograms.xml lgtm, thanks!
3 years, 8 months ago (2017-04-24 19:20:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825893003/1
3 years, 8 months ago (2017-04-25 00:38:43 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 05:22:08 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2a1375ebfbf6f242cfacf55b0930...

Powered by Google App Engine
This is Rietveld 408576698