Fix for BackgroundLoaderOffliner::OnlySavesOnceOnMultipleLoads flake?

Fix for BackgroundLoaderOffliner::OnlySavesOnceOnMultipleLoads flake?

BUG=712565
Review-Url: https://codereview.chromium.org/2825823003
Cr-Commit-Position: refs/heads/master@{#465353}
Committed: https://chromium.googlesource.com/chromium/src/+/02aac2715c6e86bd7a4c81290df414e3269d7f31

[chili, 2017-04-18 18:24:51]

The CQ bit was checked by chili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 18:25:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chili, 2017-04-18 18:27:59]

chili@chromium.org changed reviewers:
+ petewil@chromium.org

[chili, 2017-04-18 18:27:59]

If you know how to test this on the builder in question (Android n5x swarming),
please let me know :)

The test appears to be flaky about 10-20% of the time on the builder. I suspect
it's because the initialization in the CTOR but doesn't quite make sense because
the loader_ should be null on initialization, which will trigger ResetState
before the first run, which should reset all the variables.

Will see if the flakes subside after this

[dewittj, 2017-04-18 18:31:20]

If it's indeed related to uninitialized variables, you might repro locally by
making a release build of the test binary.

[Pete Williamson, 2017-04-18 18:35:12]

lgtm

[commit-bot: I haz the power, 2017-04-18 19:04:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 19:04:31]

Dry run: This issue passed the CQ dry run.

[chili, 2017-04-18 20:26:11]

The CQ bit was checked by chili@chromium.org

[commit-bot: I haz the power, 2017-04-18 20:26:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chili, 2017-04-18 20:28:47]

On 2017/04/18 18:31:20, dewittj wrote:
> If it's indeed related to uninitialized variables, you might repro locally by
> making a release build of the test binary.

Tried making local release build and running the test 101 times. No repros.

Also tried using the run_recipe script from the failing builder (passed), but
it's not very clear what it's doing...

[commit-bot: I haz the power, 2017-04-18 20:34:18]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492547171150400, "parent_rev":
"f1d77853394a703fc603f0ef0fae3cf6de9a1364", "commit_rev":
"02aac2715c6e86bd7a4c81290df414e3269d7f31"}

[commit-bot: I haz the power, 2017-04-18 20:34:37]

Description was changed from

==========
Fix for BackgroundLoaderOffliner::OnlySavesOnceOnMultipleLoads flake?

BUG=712565
==========

to

==========
Fix for BackgroundLoaderOffliner::OnlySavesOnceOnMultipleLoads flake?

BUG=712565

Review-Url: https://codereview.chromium.org/2825823003
Cr-Commit-Position: refs/heads/master@{#465353}
Committed:
https://chromium.googlesource.com/chromium/src/+/02aac2715c6e86bd7a4c81290df4...
==========

[commit-bot: I haz the power, 2017-04-18 20:34:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/02aac2715c6e86bd7a4c81290df4...