content/browser/accessibility/browser_accessibility_manager_mac.mm - Issue 2825803002: Expose internal treegrid role, do some cleanup for table/grid/treegrid handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_mac.mm

Issue 2825803002: Expose internal treegrid role, do some cleanup for table/grid/treegrid handling (Closed)

Patch Set: Expose table properties for <table role=grid> Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/accessibility/browser_accessibility_manager_mac.mm

diff --git a/content/browser/accessibility/browser_accessibility_manager_mac.mm b/content/browser/accessibility/browser_accessibility_manager_mac.mm

index c6b659b777bc5f6d505e75bb6b1e3233e9f4b5e4..7889ce8259702850e8e070d8e8e3201c94ab1441 100644

--- a/content/browser/accessibility/browser_accessibility_manager_mac.mm

+++ b/content/browser/accessibility/browser_accessibility_manager_mac.mm

@@ -211,8 +211,7 @@ void BrowserAccessibilityManagerMac::NotifyAccessibilityEvent(

mac_notification = NSAccessibilityInvalidStatusChangedNotification;

break;

case ui::AX_EVENT_SELECTED_CHILDREN_CHANGED:

- if (node->GetRole() == ui::AX_ROLE_GRID ||

- node->GetRole() == ui::AX_ROLE_TABLE) {

+ if (node->IsTableOrGridOrTreeGridRole()) {

mac_notification = NSAccessibilitySelectedRowsChangedNotification;

} else {

mac_notification = NSAccessibilitySelectedChildrenChangedNotification;