Expose internal treegrid role, do some cleanup for table/grid/treegrid handling

content/renderer/accessibility/blink_ax_tree_source.cc

Index: content/renderer/accessibility/blink_ax_tree_source.cc
diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc
index 1c89507e2e60b7668dbd7fb82dd16802317dbb6f..c8b6d9cc4c8a7c75a4cea77a525b9df9aa5369ba 100644
--- a/content/renderer/accessibility/blink_ax_tree_source.cc
+++ b/content/renderer/accessibility/blink_ax_tree_source.cc
@@ -669,7 +669,9 @@ void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,
     if (dst->role == ui::AX_ROLE_ROOT_WEB_AREA)
       dst->AddStringAttribute(ui::AX_ATTR_HTML_TAG, "#document");
 
-    if (dst->role == ui::AX_ROLE_TABLE) {
+    const bool isTableLikeRole = dst->role == ui::AX_ROLE_TABLE ||

[dmazzoni, 2017/04/18 21:59:38]

nit: is_table_like_role

[aleventhal, 2017/04/19 20:24:02]

Done.

+      dst->role == ui::AX_ROLE_GRID || dst->role == ui::AX_ROLE_TREE_GRID;
+    if (isTableLikeRole) {
       int column_count = src.ColumnCount();
       int row_count = src.RowCount();
       if (column_count > 0 && row_count > 0) {
@@ -697,11 +699,7 @@ void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,
         dst->AddIntListAttribute(ui::AX_ATTR_CELL_IDS, cell_ids);
         dst->AddIntListAttribute(ui::AX_ATTR_UNIQUE_CELL_IDS, unique_cell_ids);
       }
-    }
 
-    if (dst->role == ui::AX_ROLE_TABLE ||
-        dst->role == ui::AX_ROLE_GRID ||
-        dst->role == ui::AX_ROLE_TREE_GRID) {
       int aria_colcount = src.AriaColumnCount();
       if (aria_colcount)
         dst->AddIntAttribute(ui::AX_ATTR_ARIA_COL_COUNT, aria_colcount);