Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 2825783002: views: Remove the canvas bounds from View traces. (Closed)

Created:
3 years, 8 months ago by danakj
Modified:
3 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, enne (OOO), piman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

views: Remove the canvas bounds from View traces. These traces include getBaseLayerSize for the recording canvas which would have made more sense when they were added as that represented the area being rastered. As we are now recording instead, these bounds do not really exist except for the purpose of tracing here, so just remove them from the trace events. They were added in https://codereview.chromium.org/8440008/ which is sparse in its explanations, but I can only assume was tracking down some bad performance. We keep the traces so that they show time distribution still, but the bounds are no longer very interesting and have no relation to the time spent anyhow. R=sky@chromium.org BUG=671433 Review-Url: https://codereview.chromium.org/2825783002 Cr-Commit-Position: refs/heads/master@{#465323} Committed: https://chromium.googlesource.com/chromium/src/+/952bde5d7daf1e3627e116ce6f2ed770ef0a4913

Patch Set 1 #

Patch Set 2 : viewtraces: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M ui/views/view.cc View 1 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
danakj
3 years, 8 months ago (2017-04-18 17:32:08 UTC) #1
sky
LGTM
3 years, 8 months ago (2017-04-18 19:10:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825783002/20001
3 years, 8 months ago (2017-04-18 19:11:30 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 19:21:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/952bde5d7daf1e3627e116ce6f2e...

Powered by Google App Engine
This is Rietveld 408576698