Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 2825693002: predictors: Prefetch resources from manifest. (Closed)

Created:
3 years, 8 months ago by alexilin
Modified:
3 years, 8 months ago
Reviewers:
Benoit L
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Prefetch resources from manifest. ResourcePrefetchPredictor tries to prefetch resources from a precache manifest if there is no available prediction based on local history. This CL also adds the check for the manifest age before save it to the database. BUG=699115 Review-Url: https://codereview.chromium.org/2825693002 Cr-Commit-Position: refs/heads/master@{#465642} Committed: https://chromium.googlesource.com/chromium/src/+/ff7d03b40a6e5eaa323dd18fbc873ff868392689

Patch Set 1 #

Total comments: 15

Patch Set 2 : Address comments. #

Total comments: 2

Patch Set 3 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -31 lines) Patch
M chrome/browser/predictors/resource_prefetch_predictor.h View 1 3 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.cc View 1 2 6 chunks +77 lines, -13 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_test_util.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 1 13 chunks +86 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
alexilin
Hi lizeb, please take a look! https://codereview.chromium.org/2825693002/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc File chrome/browser/predictors/resource_prefetch_predictor.cc (right): https://codereview.chromium.org/2825693002/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc#newcode104 chrome/browser/predictors/resource_prefetch_predictor.cc:104: const base::TimeDelta kMaxManifestAge ...
3 years, 8 months ago (2017-04-18 07:05:03 UTC) #2
Benoit L
https://codereview.chromium.org/2825693002/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc File chrome/browser/predictors/resource_prefetch_predictor.cc (right): https://codereview.chromium.org/2825693002/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc#newcode921 chrome/browser/predictors/resource_prefetch_predictor.cc:921: if (base::StartsWith(manifest_host, "www.", base::CompareCase::SENSITIVE)) is www systematically stripped from ...
3 years, 8 months ago (2017-04-18 16:28:39 UTC) #3
alexilin
https://codereview.chromium.org/2825693002/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc File chrome/browser/predictors/resource_prefetch_predictor.cc (right): https://codereview.chromium.org/2825693002/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc#newcode921 chrome/browser/predictors/resource_prefetch_predictor.cc:921: if (base::StartsWith(manifest_host, "www.", base::CompareCase::SENSITIVE)) On 2017/04/18 16:28:39, Benoit L ...
3 years, 8 months ago (2017-04-19 07:59:25 UTC) #4
Benoit L
lgtm, thanks. https://codereview.chromium.org/2825693002/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc File chrome/browser/predictors/resource_prefetch_predictor.cc (right): https://codereview.chromium.org/2825693002/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc#newcode969 chrome/browser/predictors/resource_prefetch_predictor.cc:969: const float kMinPrecacheResourceWeightToTriggerPrefetch = 0.7f; On 2017/04/19 ...
3 years, 8 months ago (2017-04-19 14:48:54 UTC) #5
Benoit L
lgtm, thanks. https://codereview.chromium.org/2825693002/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc File chrome/browser/predictors/resource_prefetch_predictor.cc (right): https://codereview.chromium.org/2825693002/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc#newcode969 chrome/browser/predictors/resource_prefetch_predictor.cc:969: const float kMinPrecacheResourceWeightToTriggerPrefetch = 0.7f; On 2017/04/19 ...
3 years, 8 months ago (2017-04-19 14:48:54 UTC) #6
alexilin
https://codereview.chromium.org/2825693002/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc File chrome/browser/predictors/resource_prefetch_predictor.cc (right): https://codereview.chromium.org/2825693002/diff/1/chrome/browser/predictors/resource_prefetch_predictor.cc#newcode969 chrome/browser/predictors/resource_prefetch_predictor.cc:969: const float kMinPrecacheResourceWeightToTriggerPrefetch = 0.7f; On 2017/04/19 14:48:54, Benoit ...
3 years, 8 months ago (2017-04-19 15:35:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825693002/40001
3 years, 8 months ago (2017-04-19 15:36:23 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 17:03:24 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ff7d03b40a6e5eaa323dd18fbc87...

Powered by Google App Engine
This is Rietveld 408576698