Enable testShowJavaScriptAfterNewTabAnimation for iPad

Enable testShowJavaScriptAfterNewTabAnimation for iPad

This CL disables EG synchronization when dealing with the onload JS
dialog.

BUG=711291
Review-Url: https://codereview.chromium.org/2825673003
Cr-Commit-Position: refs/heads/master@{#465737}
Committed: https://chromium.googlesource.com/chromium/src/+/39b3663c37c90a8c6b13f50069eb017e2a1e3931

[kkhorimoto, 2017-04-18 18:30:37]

kkhorimoto@chromium.org changed reviewers:
+ baxley@chromium.org

[baxley, 2017-04-18 23:15:31]

Thanks for the detailed comment!

Just one question to make sure we don't end up in a state with another test (or
tearDown) happening before synchronization is re-enabled.

https://codereview.chromium.org/2825673003/diff/1/ios/chrome/browser/ui/dialo...
File ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm (right):

https://codereview.chromium.org/2825673003/diff/1/ios/chrome/browser/ui/dialo...
ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm:582:
forConfigKey:kGREYConfigKeySynchronizationEnabled];
Should we also add the call to enable synchronization into a teardown handler? I
don't remember offhand, but synchronization may not automatically get re-enabled
at the start of the next test.

Just for the case where the test fails after synchronization is disabled.

[kkhorimoto, 2017-04-19 18:40:18]

enable synchronization in teardown

[kkhorimoto, 2017-04-19 18:40:38]

https://codereview.chromium.org/2825673003/diff/1/ios/chrome/browser/ui/dialo...
File ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm (right):

https://codereview.chromium.org/2825673003/diff/1/ios/chrome/browser/ui/dialo...
ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm:582:
forConfigKey:kGREYConfigKeySynchronizationEnabled];
On 2017/04/18 23:15:31, baxley wrote:
> Should we also add the call to enable synchronization into a teardown handler?
I
> don't remember offhand, but synchronization may not automatically get
re-enabled
> at the start of the next test.
> 
> Just for the case where the test fails after synchronization is disabled.

Done.

[kkhorimoto, 2017-04-19 18:45:51]

actually add the change

[baxley, 2017-04-19 19:50:39]

Question about moving it to a tearDownHandler (not tearDown). I think that's
preferable, while what you have will work. LGTM

https://codereview.chromium.org/2825673003/diff/40001/ios/chrome/browser/ui/d...
File ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm (right):

https://codereview.chromium.org/2825673003/diff/40001/ios/chrome/browser/ui/d...
ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm:320:
forConfigKey:kGREYConfigKeySynchronizationEnabled];
sorry for the churn, what do you think about doing it near where the code is
enabled, in a setTearDownHandler call?

This will make it more clear that this case is handled, and only cause this to
be called within the test that needs it.

[kkhorimoto, 2017-04-19 20:27:27]

teardown handler

[kkhorimoto, 2017-04-19 20:27:27]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2017-04-19 20:27:27]

The patchset sent to the CQ was uploaded after l-g-t-m from baxley@chromium.org
Link to the patchset: https://codereview.chromium.org/2825673003/#ps60001
(title: "teardown handler")

[commit-bot: I haz the power, 2017-04-19 20:28:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 20:40:29]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492633647608570,
"parent_rev": "89c1673e0dd340f486eba92816998f839706d8f9", "commit_rev":
"39b3663c37c90a8c6b13f50069eb017e2a1e3931"}

[commit-bot: I haz the power, 2017-04-19 20:40:45]

Description was changed from

==========
Enable testShowJavaScriptAfterNewTabAnimation for iPad

This CL disables EG synchronization when dealing with the onload JS
dialog.

BUG=711291
==========

to

==========
Enable testShowJavaScriptAfterNewTabAnimation for iPad

This CL disables EG synchronization when dealing with the onload JS
dialog.

BUG=711291

Review-Url: https://codereview.chromium.org/2825673003
Cr-Commit-Position: refs/heads/master@{#465737}
Committed:
https://chromium.googlesource.com/chromium/src/+/39b3663c37c90a8c6b13f50069eb...
==========

[commit-bot: I haz the power, 2017-04-19 20:40:46]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/39b3663c37c90a8c6b13f50069eb...