Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2825663002: Split initial methods of margin on ComputedStyle. (Closed)

Created:
3 years, 8 months ago by shend
Modified:
3 years, 8 months ago
Reviewers:
nainar, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Split initial methods of margin on ComputedStyle. Currently the margin properties share the same method for the initial value: initialMargin(). This makes it difficult to generate because the generator will generate four copies of initialMargin(), causing a name conflict. This patch splits the initialMargin() method into four separate methods, one for each property. BUG=628043 Review-Url: https://codereview.chromium.org/2825663002 Cr-Commit-Position: refs/heads/master@{#465490} Committed: https://chromium.googlesource.com/chromium/src/+/c0abb68d248b76ecae92ad893db3886edd3aa59d

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 4 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
shend
Hi Naina, PTAL
3 years, 8 months ago (2017-04-18 04:53:08 UTC) #2
nainar
lgtm
3 years, 8 months ago (2017-04-18 04:54:51 UTC) #3
rune
lgtm
3 years, 8 months ago (2017-04-18 07:35:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825663002/20001
3 years, 8 months ago (2017-04-19 04:28:20 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 04:33:58 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c0abb68d248b76ecae92ad893db3...

Powered by Google App Engine
This is Rietveld 408576698