Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 2825623003: Clean up DEPS files in Blink after wtf/ removal. (Closed)

Created:
3 years, 8 months ago by Yuta Kitamura
Modified:
3 years, 8 months ago
Reviewers:
tkent, haraken
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-layout_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, kinuko+watch, kozyatinskiy+blink_chromium.org, leviw+renderwatch, lushnikov+blink_chromium.org, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up DEPS files in Blink after wtf/ removal. Now Source/wtf/ is gone, and including "wtf/XXX.h" produces a compile error. Thus, there's no need to keep DEPS entries for Source/wtf/. BUG=691465 R=haraken@chromium.org,tkent@chromium.org Review-Url: https://codereview.chromium.org/2825623003 Cr-Commit-Position: refs/heads/master@{#465168} Committed: https://chromium.googlesource.com/chromium/src/+/51980a34e4851c64267ed1515dc40d32e0727bfa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M third_party/WebKit/Source/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/public/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Yuta Kitamura
haraken: PTAL generally? tkent: PTAL at Source/DEPS?
3 years, 8 months ago (2017-04-18 04:20:22 UTC) #3
tkent
lgtm
3 years, 8 months ago (2017-04-18 04:26:48 UTC) #4
haraken
LGTM
3 years, 8 months ago (2017-04-18 07:06:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825623003/1
3 years, 8 months ago (2017-04-18 07:18:46 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 07:22:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/51980a34e4851c64267ed1515dc4...

Powered by Google App Engine
This is Rietveld 408576698