Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2825593002: DevTools: Make timeline screenshots overlay disapper quickly on mouseout (Closed)

Created:
3 years, 8 months ago by alph
Modified:
3 years, 8 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Make timeline screenshots overlay disapper quickly on mouseout BUG=711506 Review-Url: https://codereview.chromium.org/2825593002 Cr-Commit-Position: refs/heads/master@{#465094} Committed: https://chromium.googlesource.com/chromium/src/+/6be56af3695fdc2a5384108fbe01a939073a6a96

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressing comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Popover.js View 1 3 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
alph
3 years, 8 months ago (2017-04-17 23:03:48 UTC) #2
dgozman
https://codereview.chromium.org/2825593002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Popover.js File third_party/WebKit/Source/devtools/front_end/ui/Popover.js (right): https://codereview.chromium.org/2825593002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Popover.js#newcode242 third_party/WebKit/Source/devtools/front_end/ui/Popover.js:242: if (!this._hidePopoverTimer || !this._hideTimeout) Why this change? It affects ...
3 years, 8 months ago (2017-04-17 23:16:13 UTC) #3
pfeldman
not lgtm - this breaks popover. not sure how :)
3 years, 8 months ago (2017-04-17 23:38:22 UTC) #4
alph
ptal
3 years, 8 months ago (2017-04-17 23:42:30 UTC) #5
pfeldman
I mean lgtm!
3 years, 8 months ago (2017-04-18 00:03:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825593002/20001
3 years, 8 months ago (2017-04-18 00:04:41 UTC) #8
dgozman
lgtm
3 years, 8 months ago (2017-04-18 00:04:42 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 01:53:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6be56af3695fdc2a5384108fbe01...

Powered by Google App Engine
This is Rietveld 408576698