Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: tools/metrics/histograms/update_use_counter_feature_enum.py

Issue 2825573003: Update update_histogram_enum.py and update_use_counter_feature_enum.py for Blink rename (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/metrics/histograms/update_use_counter_feature_enum.py
diff --git a/tools/metrics/histograms/update_use_counter_feature_enum.py b/tools/metrics/histograms/update_use_counter_feature_enum.py
index 45a369bc12b0b302b26d47eae3f118fde4e7431a..0872999c5e34ea98c87d365fcf2af065fe8a3da8 100755
--- a/tools/metrics/histograms/update_use_counter_feature_enum.py
+++ b/tools/metrics/histograms/update_use_counter_feature_enum.py
@@ -35,15 +35,16 @@ if __name__ == '__main__':
source_path = 'third_party/WebKit/Source/core/frame/UseCounter.h'
START_MARKER = '^enum Feature : uint32_t {'
- END_MARKER = '^NumberOfFeatures'
+ END_MARKER = '^kNumberOfFeatures'
if options.dashboard:
enum_dict, ignored = ReadHistogramValues(source_path, START_MARKER,
- END_MARKER)
+ END_MARKER, strip_k_prefix = True)
Ilya Sherman 2017/04/18 05:55:09 nit: Please omit the spaces around the = sign.
Timothy Loh 2017/04/18 06:03:10 Done.
PrintEnumForDashboard(enum_dict)
else:
UpdateHistogramEnum(
histogram_enum_name='FeatureObserver',
source_enum_path=source_path,
start_marker=START_MARKER,
- end_marker=END_MARKER)
+ end_marker=END_MARKER,
+ strip_k_prefix = True)
Ilya Sherman 2017/04/18 05:55:09 nit: Please omit the spaces around the = sign.
Timothy Loh 2017/04/18 06:03:10 Done.

Powered by Google App Engine
This is Rietveld 408576698