Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: third_party/WebKit/Source/core/frame/PRESUBMIT.py

Issue 2825573003: Update update_histogram_enum.py and update_use_counter_feature_enum.py for Blink rename (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/PRESUBMIT.py
diff --git a/third_party/WebKit/Source/core/frame/PRESUBMIT.py b/third_party/WebKit/Source/core/frame/PRESUBMIT.py
index 4d105e328fc03a94b751b30f0c66e27362aec11d..ec96ed48c28a962f47e9236a9d20c60028f324c5 100644
--- a/third_party/WebKit/Source/core/frame/PRESUBMIT.py
+++ b/third_party/WebKit/Source/core/frame/PRESUBMIT.py
@@ -72,13 +72,14 @@ def _RunUmaHistogramChecks(input_api, output_api):
else:
return []
- START_MARKER = '^enum Feature : uint32_t {'
- END_MARKER = '^NumberOfFeatures'
+ start_marker = '^enum Feature : uint32_t {'
Timothy Loh 2017/04/18 05:26:11 pylint doesn't like it, I prefer to rename rather
+ end_marker = '^kNumberOfFeatures'
should_update_histogram, duplicated_values = update_histogram_enum.HistogramNeedsUpdate(
histogram_enum_name='FeatureObserver',
source_enum_path=source_path,
- start_marker=START_MARKER,
- end_marker=END_MARKER)
+ start_marker=start_marker,
+ end_marker=end_marker,
+ strip_k_prefix=True)
if duplicated_values:
return [output_api.PresubmitPromptWarning(
'UseCounter::Feature has been updated and there exists duplicated '

Powered by Google App Engine
This is Rietveld 408576698