Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2825573002:
Disable testTraceCaptureUponFailure on chromeos. (Closed)
DescriptionDisable testTraceCaptureUponFailure on chromeos.
BUG=chromium:647340
Review-Url: https://codereview.chromium.org/2825573002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/5592ae343004507c88dc6c1b96b96519f7909ec0
Patch Set 1 #
Messages
Total messages: 21 (10 generated)
Jake, PTAL
The CQ bit was checked by achuith@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
lgtm
The CQ bit was checked by achuith@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-catapult-committers". Note that this has nothing to do with OWNERS files.
achuith@chromium.org changed reviewers: + nednguyen@google.com
Ned, PTAL
On 2017/04/24 23:26:08, achuithb wrote: > Ned, PTAL lgtm But won't anyone from chromeOs team work on enable this?
The CQ bit was checked by achuith@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/04/24 23:27:29, nednguyen wrote: > On 2017/04/24 23:26:08, achuithb wrote: > > Ned, PTAL > > lgtm > > But won't anyone from chromeOs team work on enable this? I don't know enough about this test - is it an important feature?
On 2017/04/24 23:27:29, nednguyen wrote: > On 2017/04/24 23:26:08, achuithb wrote: > > Ned, PTAL > > lgtm > > But won't anyone from chromeOs team work on enable this? TimelineBasedMeasurement is the core framework that run 50% of Telemetry benchmarks these days.
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493076497758080, "parent_rev":
"892a0b6a45cc8b052638587744cc7a1b54efe2d4", "commit_rev":
"5592ae343004507c88dc6c1b96b96519f7909ec0"}
Message was sent while issue was closed.
Description was changed from ========== Disable testTraceCaptureUponFailure on chromeos. BUG=chromium:647340 ========== to ========== Disable testTraceCaptureUponFailure on chromeos. BUG=chromium:647340 Review-Url: https://codereview.chromium.org/2825573002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
