MD Settings: change outlinks to actually use <a>

chrome/browser/resources/settings/search_page/search_page.html

Index: chrome/browser/resources/settings/search_page/search_page.html
diff --git a/chrome/browser/resources/settings/search_page/search_page.html b/chrome/browser/resources/settings/search_page/search_page.html
index c05c572a56f475f578d0f244b4a544488d952a19..f0e18dbcd7dea8130520a6f6d0752eb31b9d7e0e 100644
--- a/chrome/browser/resources/settings/search_page/search_page.html
+++ b/chrome/browser/resources/settings/search_page/search_page.html
@@ -106,8 +106,9 @@
           </template>
 
           <template is="dom-if" if="[[hotwordInfo_.historyEnabled]]">
-            <div class="settings-box two-line continuation indented"
-                on-tap="onManageAudioHistoryTap_" actionable>
+            <a class="settings-box two-line continuation indented"
+                actionable tabindex="-1" target="_blank"
+                href="$i18nRaw{manageAudioHistoryUrl}">

[Dan Beam, 2017/04/20 00:28:35]

why are you using $i18nRaw{}? in case there's a & in the URL?

[scottchen, 2017/04/20 18:41:49]

Yep, as dschuyler@ reminded me.

[Dan Beam, 2017/04/20 18:44:46]

<archer>
you can...

but there's not

https://cs.chromium.org/chromium/src/chrome/common/url_constants.cc?type=cs&q...
</archer>

[scottchen, 2017/04/20 21:48:34]

Acknowledged. I went ahead and changed this to $i18n{}, as well as all the other
ones in the CL that don't actually need "Raw".

               <div class="start">
                 [[i18n('searchOkGoogleAudioHistoryLabel',
                        hotwordInfo_.userName)]]
@@ -119,7 +120,7 @@
                   aria-label$="[[i18n('searchOkGoogleAudioHistoryLabel',
                                       hotwordInfo_.userName)]]"
                   aria-describedby="audioHistorySecondary"></button>
-            </div>
+            </a>
           </template>
         </template>