MD Settings: change outlinks to actually use <a>

chrome/browser/resources/settings/search_page/search_page.html

 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
 <link rel="import" href="chrome://resources/html/md_select_css.html">
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-animatable.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">
 <link rel="import" href="../controls/extension_controlled_indicator.html">
 <link rel="import" href="../controls/settings_toggle_button.html">
 <link rel="import" href="../icons.html">
 <link rel="import" href="../i18n_setup.html">
@@ skipping 88 matching lines @@
           <template is="dom-if"
               if="[[getShowHotwordError_(hotwordInfo_.*,
                   hotwordSearchEnablePref_)]]">
             <div class="settings-box continuation indented">
               <iron-icon icon="settings:warning"></iron-icon>
               <div inner-h-t-m-l="[[hotwordInfo_.errorMessage]]"></div>
             </div>
           </template>
 
           <template is="dom-if" if="[[hotwordInfo_.historyEnabled]]">
-            <div class="settings-box two-line continuation indented"
-                on-tap="onManageAudioHistoryTap_" actionable>
+            <a class="settings-box two-line continuation indented"
+                actionable tabindex="-1" target="_blank"
+                href="$i18nRaw{manageAudioHistoryUrl}">

[Dan Beam, 2017/04/20 00:28:35]

why are you using $i18nRaw{}? in case there's a & in the URL?

[scottchen, 2017/04/20 18:41:49]

Yep, as dschuyler@ reminded me.

[Dan Beam, 2017/04/20 18:44:46]

<archer>
you can...

but there's not

https://cs.chromium.org/chromium/src/chrome/common/url_constants.cc?type=cs&q...
</archer>

[scottchen, 2017/04/20 21:48:34]

Acknowledged. I went ahead and changed this to $i18n{}, as well as all the other
ones in the CL that don't actually need "Raw".

               <div class="start">
                 [[i18n('searchOkGoogleAudioHistoryLabel',
                        hotwordInfo_.userName)]]
                 <div class="secondary" id="audioHistorySecondary">
                   $i18n{searchOkGoogleAudioHistorySubtext}
                 </div>
               </div>
               <button class="icon-external" is="paper-icon-button-light"
                   aria-label$="[[i18n('searchOkGoogleAudioHistoryLabel',
                                       hotwordInfo_.userName)]]"
                   aria-describedby="audioHistorySecondary"></button>
-            </div>
+            </a>
           </template>
         </template>
 
         <!-- Manage search engines -->
         <div id="subpage-trigger" class="settings-box"
             on-tap="onManageSearchEnginesTap_" actionable>
           <div class="start">
             $i18n{searchEnginesManage}
           </div>
           <button class="subpage-arrow" is="paper-icon-button-light"
               aria-label="$i18n{searchEnginesManage}"></button>
         </div>
       </neon-animatable>
       <template is="dom-if" route-path="/searchEngines">
         <settings-subpage
             associated-control="[[$$('#subpage-trigger')]]"
             page-title="$i18n{searchEnginesManage}">
           <settings-search-engines-page></settings-search-engines-page>
         </settings-subpage>
       </template>
     </settings-animated-pages>
   </template>
   <script src="search_page.js"></script>
 </dom-module>