Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4569)

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.js

Issue 2825493003: MD Settings: change outlinks to actually use <a> (Closed)
Patch Set: merge Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/appearance_page/appearance_page.js
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.js b/chrome/browser/resources/settings/appearance_page/appearance_page.js
index 5571b2d249929d5d2f22da0ac953f2ef182dc7fd..37a6a96e37471eeacc024b68ee7b96fa06e25525 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_page.js
+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.js
@@ -94,6 +94,9 @@ Polymer({
themeSublabel_: String,
/** @private */
+ themeUrl_: String,
+
+ /** @private */
useSystemTheme_: {
type: Boolean,
value: false, // Can only be true on Linux, but value exists everywhere.
@@ -115,9 +118,6 @@ Polymer({
/** @private {?settings.AppearanceBrowserProxy} */
browserProxy_: null,
- /** @private {string} */
- themeUrl_: '',
-
observers: [
'defaultFontSizeChanged_(prefs.webkit.webprefs.default_font_size.value)',
'themeChanged_(prefs.extensions.theme.id.value, useSystemTheme_)',
@@ -187,9 +187,13 @@ Polymer({
value - SIZE_DIFFERENCE_FIXED_STANDARD_);
},
- /** @private */
- onThemesTap_: function() {
- window.open(this.themeUrl_ || loadTimeData.getString('themesGalleryUrl'));
+ /**
+ * URL for either current theme or the theme gallery.
+ * @return {string}
+ * @private
+ */
+ getThemeHref_: function() {
+ return this.themeUrl_ || loadTimeData.getString('themesGalleryUrl');
},
// <if expr="chromeos">

Powered by Google App Engine
This is Rietveld 408576698