chrome/browser/resources/settings/appearance_page/appearance_page.html - Issue 2825493003: MD Settings: change outlinks to actually use <a>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.html

Issue 2825493003: MD Settings: change outlinks to actually use <a> (Closed)

Patch Set: merge Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/a11y_page/manage_a11y_page.js ('k') | chrome/browser/resources/settings/appearance_page/appearance_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/appearance_page/appearance_page.html

diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.html b/chrome/browser/resources/settings/appearance_page/appearance_page.html

index 06b4e12e732e12c0db2c387ac148866e16d5de13..fdf0277e55b0f5f35159085674dd93d3f3f2e3c6 100644

--- a/chrome/browser/resources/settings/appearance_page/appearance_page.html

+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.html

@@ -61,7 +61,8 @@

<div class="settings-box two-line first"

hidden="[[!pageVisibility.setTheme]]">

</if>

- <div class="start two-line" on-tap="onThemesTap_" actionable>

+ <a class="start two-line inherit-color no-outline" tabindex="-1"

+ target="_blank" href$="[[getThemeHref_(themeUrl_)]]">

$i18n{themes}

@@ -69,9 +70,9 @@

</div>

<button class="icon-external" is="paper-icon-button-light"

- aria-label="$i18n{themes}"

+ actionable aria-label="$i18n{themes}"

aria-describedby="themesSecondary"></button>

- </div>

+ </a>