Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2825493002: Implement linearVelocity and angularVelocity of VRPose for OpenVRDevice (Closed)

Created:
3 years, 8 months ago by nhu
Modified:
3 years, 8 months ago
Reviewers:
bajones, billorr
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement linearVelocity and angularVelocity of VRPose for OpenVRDevice BUG=712185 Review-Url: https://codereview.chromium.org/2825493002 Cr-Commit-Position: refs/heads/master@{#465276} Committed: https://chromium.googlesource.com/chromium/src/+/8b26cd5424a45cbcea4174b3dce53215eae4927c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M device/vr/openvr/openvr_device.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nhu
PTAL. Thanks!
3 years, 8 months ago (2017-04-17 15:04:03 UTC) #3
billorr
non-owner LGTM (you will still need to wait for Brandon to lgtm before committing).
3 years, 8 months ago (2017-04-17 17:49:08 UTC) #4
bajones
On 2017/04/17 17:49:08, billorr wrote: > non-owner LGTM (you will still need to wait for ...
3 years, 8 months ago (2017-04-17 18:13:25 UTC) #5
nhu
On 2017/04/17 18:13:25, bajones wrote: > On 2017/04/17 17:49:08, billorr wrote: > > non-owner LGTM ...
3 years, 8 months ago (2017-04-18 01:01:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825493002/1
3 years, 8 months ago (2017-04-18 17:13:10 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 17:28:16 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8b26cd5424a45cbcea4174b3dce5...

Powered by Google App Engine
This is Rietveld 408576698