Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2825473002:
ArcCustomNotificationView: Fix crash in onBlur (Closed)
|
Created:
3 years, 8 months ago by yoshiki Modified:
3 years, 8 months ago CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org, victorhsieh+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionArcCustomNotificationView: Fix crash in onBlur
When the view is being removed, the onBlur may be called with parent() == null.
This CL fixes a crash in such case.
BUG=712132
TEST=none
TBR=yhanada@chromium.org
# for this CL has gotten LGTM from yhanada@google.com
Review-Url: https://codereview.chromium.org/2825473002
Cr-Commit-Position: refs/heads/master@{#464921}
Committed: https://chromium.googlesource.com/chromium/src/+/0a8376e7800ae1d705d032c257d23b6c1738b950
Patch Set 1 #
Messages
Total messages: 22 (14 generated)
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== ArcCustomNotificationView: Fix crash in onBlur When the view is being removed, the onBlur may be called with parent() == null. This CL fixes a crash in such case. BUG=712132 TEST=none ========== to ========== ArcCustomNotificationView: Fix crash in onBlur When the view is being removed, the onBlur may be called with parent() == null. This CL fixes a crash in such case. BUG=712132 TEST=none ==========
yoshiki@chromium.org changed reviewers: + yhanada@chromium.org
Hanada-san, PTAL. Thanks.
yhanada@google.com changed reviewers: + yhanada@google.com
lgtm
The CQ bit was checked by yoshiki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== ArcCustomNotificationView: Fix crash in onBlur When the view is being removed, the onBlur may be called with parent() == null. This CL fixes a crash in such case. BUG=712132 TEST=none ========== to ========== ArcCustomNotificationView: Fix crash in onBlur When the view is being removed, the onBlur may be called with parent() == null. This CL fixes a crash in such case. BUG=712132 TEST=none TBR=yhanada@chromium.org # for this CL has gotten approval from yhanada@google.com ==========
Description was changed from ========== ArcCustomNotificationView: Fix crash in onBlur When the view is being removed, the onBlur may be called with parent() == null. This CL fixes a crash in such case. BUG=712132 TEST=none TBR=yhanada@chromium.org # for this CL has gotten approval from yhanada@google.com ========== to ========== ArcCustomNotificationView: Fix crash in onBlur When the view is being removed, the onBlur may be called with parent() == null. This CL fixes a crash in such case. BUG=712132 TEST=none TBR=yhanada@chromium.org # for this CL has gotten LGTM from yhanada@google.com ==========
The CQ bit was checked by yoshiki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Sorry, I replied from wrong account...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492437527901520, "parent_rev":
"7477d8753869cdfa023a570c8eca3cbaf29db761", "commit_rev":
"0a8376e7800ae1d705d032c257d23b6c1738b950"}
Message was sent while issue was closed.
Description was changed from ========== ArcCustomNotificationView: Fix crash in onBlur When the view is being removed, the onBlur may be called with parent() == null. This CL fixes a crash in such case. BUG=712132 TEST=none TBR=yhanada@chromium.org # for this CL has gotten LGTM from yhanada@google.com ========== to ========== ArcCustomNotificationView: Fix crash in onBlur When the view is being removed, the onBlur may be called with parent() == null. This CL fixes a crash in such case. BUG=712132 TEST=none TBR=yhanada@chromium.org # for this CL has gotten LGTM from yhanada@google.com Review-Url: https://codereview.chromium.org/2825473002 Cr-Commit-Position: refs/heads/master@{#464921} Committed: https://chromium.googlesource.com/chromium/src/+/0a8376e7800ae1d705d032c257d2... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0a8376e7800ae1d705d032c257d2... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
