Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2825443002: Replace sizeof(kGainCycleLength) with kGainCycleLength. This fortunately does not have impact on t… (Closed)

Created:
3 years, 8 months ago by Victor Vasiliev
Modified:
3 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace sizeof(kGainCycleLength) with kGainCycleLength. This fortunately does not have impact on the server side (where BBR is currently enabled via an experiment), since those two values both happen to be 8. On Windows and Android, this will result in expanding the possible set of starting gain cycling offsets from 3 to 7. This was reported by Felix Weinrank. Merge internal change: 152933950 R=rch@chromium.org BUG= Review-Url: https://codereview.chromium.org/2825443002 Cr-Commit-Position: refs/heads/master@{#464933} Committed: https://chromium.googlesource.com/chromium/src/+/cffb01887fc1b0719aea82138aef58a1054405a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M net/quic/core/congestion_control/bbr_sender.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Victor Vasiliev
3 years, 8 months ago (2017-04-17 07:11:04 UTC) #1
Ryan Hamilton
lgtm
3 years, 8 months ago (2017-04-17 13:29:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825443002/1
3 years, 8 months ago (2017-04-17 13:30:07 UTC) #4
Ryan Hamilton
If it is a merge, please mention the original CL in the description before landing.
3 years, 8 months ago (2017-04-17 14:03:25 UTC) #6
Victor Vasiliev
On 2017/04/17 14:03:25, Ryan Hamilton wrote: > If it is a merge, please mention the ...
3 years, 8 months ago (2017-04-17 16:16:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825443002/1
3 years, 8 months ago (2017-04-17 16:16:27 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 17:01:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cffb01887fc1b0719aea82138aef...

Powered by Google App Engine
This is Rietveld 408576698