Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2825403002: Remove navigator.vibrate without user gesture. (Closed)

Created:
3 years, 8 months ago by gogerald1
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Remove navigator.vibrate without user gesture. Calls to navigator.vibrate will immediately return 'false' if user hasn't tapped on the frame or any embedded frame yet. The implementation is behind an experimental flag. The Intent to Deprecate thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QGcpjisxtik BUG=704650 Review-Url: https://codereview.chromium.org/2778693004 Cr-Commit-Position: refs/heads/master@{#465618} (cherry picked from commit c5b59119ca57398e87a692c9ea836efee2627966) Review-Url: https://codereview.chromium.org/2825403002 . Cr-Commit-Position: refs/branch-heads/3071@{#54} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/54365e69605bb69a531764a8be7f398ede395131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+342 lines, -239 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/feature-policy-vibrate-disabled.html View 1 chunk +16 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/feature-policy-vibrate-enabled.html View 1 chunk +21 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/feature-policy/vibrate-disabled-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/feature-policy/vibrate-enabledforall.php View 1 chunk +13 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/feature-policy/vibrate-enabledforself.php View 1 chunk +13 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/resources/cross-origin-iframe-for-vibrate-blocked.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/resources/cross-origin-iframe-for-vibrate-with-user-gesture-allowed.html View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/resources/same-origin-iframe-for-vibrate-allowed.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/vibrate_in_cross_origin_iframe_blocked.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/vibrate_in_cross_origin_iframe_blocked-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/vibrate_in_cross_origin_iframe_with_user_gesture_allowed.html View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/vibrate_in_cross_origin_iframe_with_user_gesture_allowed-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/vibrate_in_same_origin_iframe_allowed.html View 1 chunk +0 lines, -15 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/security/vibration/resources/vibrate-in-cross-origin-iframe-blocked.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/security/vibration/resources/vibrate-in-iframe-with-user-gesture-allowed.html View 3 chunks +9 lines, -15 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/security/vibration/resources/vibrate-in-same-origin-iframe-with-user-gesture-allowed.html View 3 chunks +11 lines, -17 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/vibration/resources/vibrate-with-user-gesture-allowed.html View 1 chunk +27 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-cross-origin-iframe-blocked.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-cross-origin-iframe-blocked-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-cross-origin-iframe-with-user-gesture-allowed.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-cross-origin-iframe-with-user-gesture-allowed-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-same-origin-iframe-with-user-gesture-allowed.html View 2 chunks +3 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-in-same-origin-iframe-with-user-gesture-allowed-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-on-top-page-before-during-after-user-gesture.html View 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/vibration/vibrate-on-top-page-before-during-after-user-gesture-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/resources/user-gesture-utils.js View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/vibration/cancel-vibration-during-pattern-vibrating.html View 2 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/vibration/resources/vibrate-from-iframe.html View 1 chunk +26 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/vibration/vibration.html View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/vibration/vibration-durations.html View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/vibration/vibration-exceptions.html View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/vibration/vibration-iframe-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/vibration/vibration-page-visibility.html View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/vibration/vibration-patterns.html View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp View 2 chunks +28 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
gogerald1
3 years, 8 months ago (2017-04-19 17:10:29 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
54365e69605bb69a531764a8be7f398ede395131.

Powered by Google App Engine
This is Rietveld 408576698