Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/event-after-starting.html

Issue 2825393004: bluetooth: Check the order of event and promise resolution for readValue (Closed)
Patch Set: Address moar feedback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/event-after-starting.html
diff --git a/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/event-after-starting.html b/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/event-after-starting.html
index eaae9fd549928907a1527fb11a4ee6dd827c8c2b..e9fb075f57efaa41c25f7f4d7a9a2e9c17464963 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/event-after-starting.html
+++ b/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/event-after-starting.html
@@ -12,9 +12,8 @@ promise_test(() => {
.then(gattServer => gattServer.getPrimaryService('heart_rate'))
.then(service => service.getCharacteristic('heart_rate_measurement'))
.then(characteristic => {
- return assert_event_fires_after_promise(
- characteristic, 'startNotifications', 'characteristicvaluechanged',
- 1 /* attach 1 listener */, false /* ignore_event_promise_order */)
+ return assert_promise_resolves_before_event(
+ characteristic, 'startNotifications', 'characteristicvaluechanged')
.then(() => characteristic.stopNotifications())
.then(() => assert_no_events(characteristic,
'characteristicvaluechanged'));

Powered by Google App Engine
This is Rietveld 408576698