Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/add-multiple-event-listeners.html

Issue 2825393004: bluetooth: Check the order of event and promise resolution for readValue (Closed)
Patch Set: Address moar feedback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/event-after-starting.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/add-multiple-event-listeners.html
diff --git a/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/add-multiple-event-listeners.html b/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/add-multiple-event-listeners.html
index 6b2d2bc893d059cbc6fa1492005db0dadaadb0b4..e3157a35ed7858c5b2d7f10ace1d41357f2aa60a 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/add-multiple-event-listeners.html
+++ b/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/add-multiple-event-listeners.html
@@ -14,11 +14,10 @@ promise_test(() => {
.then(service => service.getCharacteristic('heart_rate_measurement'))
.then(characteristic => {
char = characteristic;
- return assert_event_fires_after_promise(characteristic,
- 'startNotifications',
- 'characteristicvaluechanged',
- 3 /* add 3 listeners */,
- false /* ignore_event_promise_order */);
+ return assert_promise_resolves_before_event(characteristic,
+ 'startNotifications',
+ 'characteristicvaluechanged',
+ 3 /* add 3 listeners */);
})
.then(() => char.stopNotifications())
.then(() => assert_no_events(char, 'characteristicvaluechanged'));
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/event-after-starting.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698